Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc(FieldTheory/Finiteness): fix docstring #11151

Closed
wants to merge 1 commit into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Mar 4, 2024


The namespace of finsetBasisIndex was changed three years ago in mathlib3 leanprover-community/mathlib#7644 from (mathlib3 names) finite_dimensional to is_noetherian, but this docstring was not updated.

Open in Gitpod

@kbuzzard kbuzzard added awaiting-review The author would like community review of the PR documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 4, 2024
@ADedecker
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 4, 2024
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(FieldTheory/Finiteness): fix docstring [Merged by Bors] - doc(FieldTheory/Finiteness): fix docstring Mar 4, 2024
@mathlib-bors mathlib-bors bot closed this Mar 4, 2024
@mathlib-bors mathlib-bors bot deleted the kbuzzard-finsetBasis-docstring branch March 4, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants