Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: update unexpanders #11165

Closed
wants to merge 2 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Mar 5, 2024

lean4#3375 makes it so that unexpanders do not need to handle overapplication.


Open in Gitpod

lean4#3375 makes it so that unexpanders do not need to handle overapplication.
@kmill kmill added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Mar 5, 2024
@kmill
Copy link
Contributor Author

kmill commented Mar 5, 2024

@PatrickMassot As a delaborator connoisseur, I thought I'd ping you to mention that the unexpander overapplication feature that landed works.

I also changed your test. It was checking that p.1 22 pretty prints as p.fst 22, but p.1 22 is what you want, right?

@PatrickMassot
Copy link
Member

I also changed your test. It was checking that p.1 22 pretty prints as p.fst 22, but p.1 22 is what you want, right?

Yes, I wanted p.1 22.

@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 5, 2024
lean4#3375 makes it so that unexpanders do not need to handle overapplication.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: update unexpanders [Merged by Bors] - chore: update unexpanders Mar 5, 2024
@mathlib-bors mathlib-bors bot closed this Mar 5, 2024
@mathlib-bors mathlib-bors bot deleted the kmill_unexpander_review branch March 5, 2024 19:57
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
lean4#3375 makes it so that unexpanders do not need to handle overapplication.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
lean4#3375 makes it so that unexpanders do not need to handle overapplication.
utensil pushed a commit that referenced this pull request Mar 26, 2024
lean4#3375 makes it so that unexpanders do not need to handle overapplication.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
lean4#3375 makes it so that unexpanders do not need to handle overapplication.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
lean4#3375 makes it so that unexpanders do not need to handle overapplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants