Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: let congr! discharge equalities of BEq instances #11179

Closed
wants to merge 3 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Mar 5, 2024

Adds a congruence lemma for BEq instances that makes use of LawfulBEq instances, and gives congr! the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the beqEq configuration setting, like congr! (config := { beqEq := false }).


Open in Gitpod

Adds a congruence lemma for `BEq` instances that makes use of `LawfulBEq` instances, and gives `congr!` the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the `beqEq` configuration setting, like `congr! (config := { beqEq := false })`.
@kmill kmill added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Mar 5, 2024
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 21, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 21, 2024
Adds a congruence lemma for `BEq` instances that makes use of `LawfulBEq` instances, and gives `congr!` the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the `beqEq` configuration setting, like `congr! (config := { beqEq := false })`.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: let congr! discharge equalities of BEq instances [Merged by Bors] - feat: let congr! discharge equalities of BEq instances Mar 22, 2024
@mathlib-bors mathlib-bors bot closed this Mar 22, 2024
@mathlib-bors mathlib-bors bot deleted the kmill_congr_beq branch March 22, 2024 01:10
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Adds a congruence lemma for `BEq` instances that makes use of `LawfulBEq` instances, and gives `congr!` the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the `beqEq` configuration setting, like `congr! (config := { beqEq := false })`.
utensil pushed a commit that referenced this pull request Mar 26, 2024
Adds a congruence lemma for `BEq` instances that makes use of `LawfulBEq` instances, and gives `congr!` the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the `beqEq` configuration setting, like `congr! (config := { beqEq := false })`.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Adds a congruence lemma for `BEq` instances that makes use of `LawfulBEq` instances, and gives `congr!` the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the `beqEq` configuration setting, like `congr! (config := { beqEq := false })`.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Adds a congruence lemma for `BEq` instances that makes use of `LawfulBEq` instances, and gives `congr!` the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the `beqEq` configuration setting, like `congr! (config := { beqEq := false })`.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Adds a congruence lemma for `BEq` instances that makes use of `LawfulBEq` instances, and gives `congr!` the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the `beqEq` configuration setting, like `congr! (config := { beqEq := false })`.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Adds a congruence lemma for `BEq` instances that makes use of `LawfulBEq` instances, and gives `congr!` the ability to use this congruence lemma. This is meant to help with diamonds that arise from interactions between Decidable and BEq instances.

This feature can be turned off using the `beqEq` configuration setting, like `congr! (config := { beqEq := false })`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants