Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: cons lemmas for Finset.noncommProd #11194

Closed
wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 6, 2024

These are more general than the insert versions as they do not assume DecidableEq.

This also lets some later proofs be golfed.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Mar 6, 2024
Mathlib/Data/Finset/NoncommProd.lean Outdated Show resolved Hide resolved
Mathlib/Data/Finset/NoncommProd.lean Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 12, 2024
These are more general than the `insert` versions as they do not assume `DecidableEq`.

This also lets some later proofs be golfed.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: cons lemmas for Finset.noncommProd [Merged by Bors] - feat: cons lemmas for Finset.noncommProd Mar 12, 2024
@mathlib-bors mathlib-bors bot closed this Mar 12, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/noncommProd branch March 12, 2024 11:06
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
These are more general than the `insert` versions as they do not assume `DecidableEq`.

This also lets some later proofs be golfed.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
These are more general than the `insert` versions as they do not assume `DecidableEq`.

This also lets some later proofs be golfed.
utensil pushed a commit that referenced this pull request Mar 26, 2024
These are more general than the `insert` versions as they do not assume `DecidableEq`.

This also lets some later proofs be golfed.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
These are more general than the `insert` versions as they do not assume `DecidableEq`.

This also lets some later proofs be golfed.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
These are more general than the `insert` versions as they do not assume `DecidableEq`.

This also lets some later proofs be golfed.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
These are more general than the `insert` versions as they do not assume `DecidableEq`.

This also lets some later proofs be golfed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants