[Merged by Bors] - chore: scope open Classical
#11199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace with `open scoped Classical\nopen $1`
we replace with `open scoped Classical\nopen $1$2$3`
ericrbg
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
We remove all but one `open Classical`s, instead preferring to use `open scoped Classical`. The only real side-effect this led to is moving a couple declarations to use `Exists.choose` instead of `Classical.choose`. The first few commits are explicitly labelled regex replaces for ease of review.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
open Classicalopen Classical
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
We remove all but one `open Classical`s, instead preferring to use `open scoped Classical`. The only real side-effect this led to is moving a couple declarations to use `Exists.choose` instead of `Classical.choose`. The first few commits are explicitly labelled regex replaces for ease of review.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
We remove all but one `open Classical`s, instead preferring to use `open scoped Classical`. The only real side-effect this led to is moving a couple declarations to use `Exists.choose` instead of `Classical.choose`. The first few commits are explicitly labelled regex replaces for ease of review.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
We remove all but one `open Classical`s, instead preferring to use `open scoped Classical`. The only real side-effect this led to is moving a couple declarations to use `Exists.choose` instead of `Classical.choose`. The first few commits are explicitly labelled regex replaces for ease of review.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
We remove all but one `open Classical`s, instead preferring to use `open scoped Classical`. The only real side-effect this led to is moving a couple declarations to use `Exists.choose` instead of `Classical.choose`. The first few commits are explicitly labelled regex replaces for ease of review.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
We remove all but one `open Classical`s, instead preferring to use `open scoped Classical`. The only real side-effect this led to is moving a couple declarations to use `Exists.choose` instead of `Classical.choose`. The first few commits are explicitly labelled regex replaces for ease of review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove all but one
open Classicals, instead preferring to useopen scoped Classical. The only real side-effect this led to is moving a couple declarations to useExists.chooseinstead ofClassical.choose.The first few commits are explicitly labelled regex replaces for ease of review.