Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: use polyrith/linear_combination in Algebra/Star/CHSH #11211

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: use polyrith/linear_combination in Algebra/Star/CHSH #11211

wants to merge 1 commit into from

Conversation

semorrison
Copy link
Contributor

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 7, 2024
grunweg
grunweg approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this is a nice little clean-up.

I presume you're not using says because

  • polyrith is a self-replacing tactic
  • we don't want/cannot run sage on CI, right?

Are you aware of other such places? (Searching mathlib for "Gröbner" didn't yield other hits.)

@adomani
Copy link
Collaborator

adomani commented Mar 14, 2024

Thanks!

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by adomani.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 14, 2024
@semorrison
feat: use polyrith/linear_combination in Algebra/Star/CHSH (#11211)
bbb8984 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: use polyrith/linear_combination in Algebra/Star/CHSH [Merged by Bors] - feat: use polyrith/linear_combination in Algebra/Star/CHSH Mar 14, 2024
@mathlib-bors mathlib-bors bot closed this Mar 14, 2024
@mathlib-bors mathlib-bors bot deleted the chsh_polyrith branch March 14, 2024 18:30
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@semorrison @dagurtomas
feat: use polyrith/linear_combination in Algebra/Star/CHSH (#11211)
cab1248 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
utensil pushed a commit that referenced this pull request Mar 26, 2024
@semorrison @utensil
feat: use polyrith/linear_combination in Algebra/Star/CHSH (#11211)
c9a64d8 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@semorrison @Louddy
feat: use polyrith/linear_combination in Algebra/Star/CHSH (#11211)
e5c5aa7 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@semorrison @uniwuni
feat: use polyrith/linear_combination in Algebra/Star/CHSH (#11211)
836c1a2 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@semorrison @callesonne
feat: use polyrith/linear_combination in Algebra/Star/CHSH (#11211)
dc283b6 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunweg grunweg grunweg approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @adomani @riccardobrasca @grunweg