[Merged by Bors] - fix(slim_check): do not crash when binders contain a function type #11231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
bug
eric-wieser
added
the
awaiting-review
YaelDillies
approved these changes
Mar 22, 2024
Comment on lines
+512
to
+513
| if not (← Meta.inferType expr).isProp then | ||
| return .done expr |
There was a problem hiding this comment.
I find the meaning clearer this way (although I know you weren't the one introducing this spelling).
Suggested change
| if not (← Meta.inferType expr).isProp then | |
| return .done expr | |
| unless (← Meta.inferType expr).isProp | |
| return .done expr |
There was a problem hiding this comment.
Does unless support else? I think in an else/if chain, using unless makes things a little weirder to read.
There was a problem hiding this comment.
I don't think it does, but I claim that's a feature. The unless clause indicates a condition on which you want to immediately abort, which is not what an else/if chain indicates.
There was a problem hiding this comment.
I'm going to use "this if isn't really part of this patch" to avoid having to do anything in this CL. If you feel strongly that unless is underused, perhaps open a follow-up with 10 or so replacements across mathlib and see what people think.
bors merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
…11231) Previously ```lean import Mathlib open scoped BigOperators in example (n : ℕ) : ∑ f : Unit → Fin (n + 1), f () = 0 := by slim_check ``` failed with ``` application type mismatch SlimCheck.NamedBinder "a._@._hyg.23" (Unit → Fin (n + 1)) argument Unit → Fin (n + 1) has type Type : Type 1 but is expected to have type Prop : Type ```
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
…11231) Previously ```lean import Mathlib open scoped BigOperators in example (n : ℕ) : ∑ f : Unit → Fin (n + 1), f () = 0 := by slim_check ``` failed with ``` application type mismatch SlimCheck.NamedBinder "a._@._hyg.23" (Unit → Fin (n + 1)) argument Unit → Fin (n + 1) has type Type : Type 1 but is expected to have type Prop : Type ```
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…11231) Previously ```lean import Mathlib open scoped BigOperators in example (n : ℕ) : ∑ f : Unit → Fin (n + 1), f () = 0 := by slim_check ``` failed with ``` application type mismatch SlimCheck.NamedBinder "a._@._hyg.23" (Unit → Fin (n + 1)) argument Unit → Fin (n + 1) has type Type : Type 1 but is expected to have type Prop : Type ```
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
…11231) Previously ```lean import Mathlib open scoped BigOperators in example (n : ℕ) : ∑ f : Unit → Fin (n + 1), f () = 0 := by slim_check ``` failed with ``` application type mismatch SlimCheck.NamedBinder "a._@._hyg.23" (Unit → Fin (n + 1)) argument Unit → Fin (n + 1) has type Type : Type 1 but is expected to have type Prop : Type ```
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
…11231) Previously ```lean import Mathlib open scoped BigOperators in example (n : ℕ) : ∑ f : Unit → Fin (n + 1), f () = 0 := by slim_check ``` failed with ``` application type mismatch SlimCheck.NamedBinder "a._@._hyg.23" (Unit → Fin (n + 1)) argument Unit → Fin (n + 1) has type Type : Type 1 but is expected to have type Prop : Type ```
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
…11231) Previously ```lean import Mathlib open scoped BigOperators in example (n : ℕ) : ∑ f : Unit → Fin (n + 1), f () = 0 := by slim_check ``` failed with ``` application type mismatch SlimCheck.NamedBinder "a._@._hyg.23" (Unit → Fin (n + 1)) argument Unit → Fin (n + 1) has type Type : Type 1 but is expected to have type Prop : Type ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
failed with