Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(LinearAlgebra/Projectivization/Independence): use DivisionRing instead of Field #11232

Closed
wants to merge 1 commit into from

Conversation

oneofvalts
Copy link
Collaborator

@oneofvalts oneofvalts commented Mar 7, 2024

I need $K$ to be a skew field instead of a field to prove that projectivization of a vector space is a projective geometry stated in proposition 2.1.6 in the book "Modern Projective Geometry" by Claude-Alain Faure and Alfred Frölicher, see p. 27-28. In p.27, just before the proposition, it is noted that "... $K$ is allowed to be a skew field (often called division ring)."


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI labels Mar 9, 2024
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you add some one or two-sentence explanation in the PR description about why this is reasonable? Something like "I need this to follow <some paper/textbook>", or "I need this to construct <something more general>".

@oneofvalts
Copy link
Collaborator Author

LGTM

Can you add some one or two-sentence explanation in the PR description about why this is reasonable? Something like "I need this to follow <some paper/textbook>", or "I need this to construct ".

Thank you, done!

@eric-wieser
Copy link
Member

bors merge

Thanks!

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 10, 2024

👎 Rejected by label

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 10, 2024
@eric-wieser
Copy link
Member

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Mar 10, 2024
…stead of Field (#11232)

I need $K$ to be a skew field instead of a field to prove that projectivization of a vector space is a projective geometry stated in proposition 2.1.6 in the book "Modern Projective Geometry" by Claude-Alain Faure and Alfred Frölicher, see p. 27-28. In p.27, just before the proposition, it is noted that "... $K$ is allowed to be a skew field (often called *division ring*)."
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(LinearAlgebra/Projectivization/Independence): use DivisionRing instead of Field [Merged by Bors] - fix(LinearAlgebra/Projectivization/Independence): use DivisionRing instead of Field Mar 10, 2024
@mathlib-bors mathlib-bors bot closed this Mar 10, 2024
@mathlib-bors mathlib-bors bot deleted the field_generalization branch March 10, 2024 13:12
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
…stead of Field (#11232)

I need $K$ to be a skew field instead of a field to prove that projectivization of a vector space is a projective geometry stated in proposition 2.1.6 in the book "Modern Projective Geometry" by Claude-Alain Faure and Alfred Frölicher, see p. 27-28. In p.27, just before the proposition, it is noted that "... $K$ is allowed to be a skew field (often called *division ring*)."
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
…stead of Field (#11232)

I need $K$ to be a skew field instead of a field to prove that projectivization of a vector space is a projective geometry stated in proposition 2.1.6 in the book "Modern Projective Geometry" by Claude-Alain Faure and Alfred Frölicher, see p. 27-28. In p.27, just before the proposition, it is noted that "... $K$ is allowed to be a skew field (often called *division ring*)."
utensil pushed a commit that referenced this pull request Mar 26, 2024
…stead of Field (#11232)

I need $K$ to be a skew field instead of a field to prove that projectivization of a vector space is a projective geometry stated in proposition 2.1.6 in the book "Modern Projective Geometry" by Claude-Alain Faure and Alfred Frölicher, see p. 27-28. In p.27, just before the proposition, it is noted that "... $K$ is allowed to be a skew field (often called *division ring*)."
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…stead of Field (#11232)

I need $K$ to be a skew field instead of a field to prove that projectivization of a vector space is a projective geometry stated in proposition 2.1.6 in the book "Modern Projective Geometry" by Claude-Alain Faure and Alfred Frölicher, see p. 27-28. In p.27, just before the proposition, it is noted that "... $K$ is allowed to be a skew field (often called *division ring*)."
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…stead of Field (#11232)

I need $K$ to be a skew field instead of a field to prove that projectivization of a vector space is a projective geometry stated in proposition 2.1.6 in the book "Modern Projective Geometry" by Claude-Alain Faure and Alfred Frölicher, see p. 27-28. In p.27, just before the proposition, it is noted that "... $K$ is allowed to be a skew field (often called *division ring*)."
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…stead of Field (#11232)

I need $K$ to be a skew field instead of a field to prove that projectivization of a vector space is a projective geometry stated in proposition 2.1.6 in the book "Modern Projective Geometry" by Claude-Alain Faure and Alfred Frölicher, see p. 27-28. In p.27, just before the proposition, it is noted that "... $K$ is allowed to be a skew field (often called *division ring*)."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants