feat: a non-terminal simp linter #11246
Open
+100
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
added
awaiting-review
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 10, 2024
The squeezing continues! All found by the linter at #11246.
adomani
force-pushed
the
adomani/ntsLinter
branch
from
950732f
to
de6d27f
Compare
adomani
force-pushed
the
adomani/ntsLinter
branch
from
de6d27f
to
71263f3
Compare
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
The squeezing continues! All found by the linter at #11246.
|
This is great! Is it possible to add a whitelist for some following tactics, for instance it has been agreed on zulip in the past that some patterns like |
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
The squeezing continues! All found by the linter at #11246.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
The squeezing continues! All found by the linter at #11246.
leanprover-community-mathlib4-bot
added
the
merge-conflict
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
The squeezing continues! All found by the linter at #11246.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
The squeezing continues! All found by the linter at #11246.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
The squeezing continues! All found by the linter at #11246.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of a syntax+
InfoTrees linter checking for non-terminalsimps.The linter equates "non-terminal" with "does not strictly decrease the number of goals".
Accompanying PRs squeezing a few of the
simps flagged by the linter:squeeze_simps arising from linter #11259Zulip threads: