Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(Equiv/TransferInstance): move to_additive attribute #11277

Closed
wants to merge 1 commit into from

Conversation

chrisflav
Copy link
Collaborator

Removes to_additive from a MulZeroClass instance and instead puts it on the corresponding MulOneClass instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).


Open in Gitpod

@chrisflav chrisflav added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Mar 10, 2024
@chrisflav chrisflav changed the title fix(Equiv/TransferInstance): fixes to_additive attribute fix(Equiv/TransferInstance): move to_additive attribute Mar 10, 2024
@chrisflav chrisflav changed the title fix(Equiv/TransferInstance): move to_additive attribute fix(Equiv/TransferInstance): move to_additive attribute Mar 10, 2024
@eric-wieser
Copy link
Member

bors d+

Thanks!

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 10, 2024

✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR awaiting-CI labels Mar 10, 2024
@eric-wieser
Copy link
Member

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Mar 10, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 10, 2024
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Equiv/TransferInstance): move to_additive attribute [Merged by Bors] - fix(Equiv/TransferInstance): move to_additive attribute Mar 10, 2024
@mathlib-bors mathlib-bors bot closed this Mar 10, 2024
@mathlib-bors mathlib-bors bot deleted the chrisflav/univle-moncat branch March 10, 2024 14:17
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
utensil pushed a commit that referenced this pull request Mar 26, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants