New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix(Equiv/TransferInstance): move to_additive
attribute
#11277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisflav
added
awaiting-review
The author would like community review of the PR
easy
< 20s of review time. See the lifecycle page for guidelines.
awaiting-CI
labels
Mar 10, 2024
chrisflav
changed the title
fix(Equiv/TransferInstance): fixes to_additive attribute
fix(Equiv/TransferInstance): move to_additive attribute
Mar 10, 2024
chrisflav
changed the title
fix(Equiv/TransferInstance): move to_additive attribute
fix(Equiv/TransferInstance): move Mar 10, 2024
to_additive
attribute
bors d+ Thanks! |
✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
The author would like community review of the PR
awaiting-CI
labels
Mar 10, 2024
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 10, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
fix(Equiv/TransferInstance): move
[Merged by Bors] - fix(Equiv/TransferInstance): move Mar 10, 2024
to_additive
attributeto_additive
attribute
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Removes `to_additive` from a `MulZeroClass` instance and instead puts it on the corresponding `MulOneClass` instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
easy
< 20s of review time. See the lifecycle page for guidelines.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
to_additive
from aMulZeroClass
instance and instead puts it on the correspondingMulOneClass
instance (more explanation here: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/to_additive.20on.20MulZeroClass).