Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Feat port algebra.order.positive.field #1129

Closed
wants to merge 8 commits into from

Conversation

arienmalec
Copy link
Collaborator

Port of Algebra.Order.Positive.Field

based on bbeb185db4ccee8ed07dc48449414ebfa39cb821

@arienmalec arienmalec added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Dec 20, 2022
@arienmalec arienmalec added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Dec 20, 2022
@arienmalec
Copy link
Collaborator Author

Credit to @kbuzzard for the actual fixes (I just did the gruntwork here)

@arienmalec arienmalec changed the title Feat port algebra order positive field Feat port algebra.order.positive.field Dec 21, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 21, 2022
bors bot pushed a commit that referenced this pull request Dec 21, 2022
Port of Algebra.Order.Positive.Field

based on bbeb185db4ccee8ed07dc48449414ebfa39cb821
@bors
Copy link

bors bot commented Dec 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Feat port algebra.order.positive.field [Merged by Bors] - Feat port algebra.order.positive.field Dec 21, 2022
@bors bors bot closed this Dec 21, 2022
@bors bors bot deleted the feat-port-algebra-order-positive-field branch December 21, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants