Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.SmulWithZero #1130

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Algebra.SmulWithZero #1130

wants to merge 5 commits into from

Conversation

antoinelab01
Copy link
Collaborator

@antoinelab01 antoinelab01 commented Dec 20, 2022 •
edited by bors bot

No description provided.

@antoinelab01 antoinelab01 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 20, 2022
@antoinelab01 antoinelab01 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 20, 2022
jcommelin
jcommelin approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 21, 2022
bors bot pushed a commit that referenced this pull request Dec 21, 2022
@antoinelab01
feat: port Algebra.SmulWithZero (#1130)
489f104
@bors
Copy link

bors bot commented Dec 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.SmulWithZero [Merged by Bors] - feat: port Algebra.SmulWithZero Dec 21, 2022
@bors bors bot closed this Dec 21, 2022
@bors bors bot deleted the antoinelab01/SmulWithZero branch December 21, 2022 06:01
@github-actions github-actions bot mentioned this pull request Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antoinelab01 @jcommelin @semorrison