Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(Analysis/Convex/Combination): resolve one easy porting note #11306

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix(Analysis/Convex/Combination): resolve one easy porting note #11306

wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Mar 11, 2024

Open in Gitpod

@grunweg grunweg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 11, 2024
@mcdoll
Copy link
Member

mcdoll commented Mar 11, 2024

Thanks!
maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by mcdoll.

jcommelin
jcommelin approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 12, 2024
@grunweg
fix(Analysis/Convex/Combination): resolve one easy porting note (#11306)
0ffa9b6
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Analysis/Convex/Combination): resolve one easy porting note [Merged by Bors] - fix(Analysis/Convex/Combination): resolve one easy porting note Mar 12, 2024
@mathlib-bors mathlib-bors bot closed this Mar 12, 2024
@mathlib-bors mathlib-bors bot deleted the MR-convex-porting-notes branch March 12, 2024 06:50
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
@grunweg @kbuzzard
fix(Analysis/Convex/Combination): resolve one easy porting note (#11306)
65e255a
@grunweg grunweg added the porting-notes Mathlib3 to Mathlib4 porting notes. label Mar 16, 2024
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@grunweg @dagurtomas
fix(Analysis/Convex/Combination): resolve one easy porting note (#11306)
35e0128
utensil pushed a commit that referenced this pull request Mar 26, 2024
@grunweg @utensil
fix(Analysis/Convex/Combination): resolve one easy porting note (#11306)
407d98f
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@grunweg @Louddy
fix(Analysis/Convex/Combination): resolve one easy porting note (#11306)
9c60dfa
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@grunweg @uniwuni
fix(Analysis/Convex/Combination): resolve one easy porting note (#11306)
fb04d15
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@grunweg @callesonne
fix(Analysis/Convex/Combination): resolve one easy porting note (#11306)
2251322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grunweg @mcdoll @jcommelin @leanprover-community-mathlib4-bot