Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove superseded small_of_fintype #11326

Closed
wants to merge 11 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Mathlib.lean
Original file line number Diff line number Diff line change
Expand Up @@ -1715,7 +1715,6 @@ import Mathlib.Data.Fintype.Powerset
import Mathlib.Data.Fintype.Prod
import Mathlib.Data.Fintype.Quotient
import Mathlib.Data.Fintype.Sigma
import Mathlib.Data.Fintype.Small
import Mathlib.Data.Fintype.Sort
import Mathlib.Data.Fintype.Sum
import Mathlib.Data.Fintype.Units
Expand Down
12 changes: 10 additions & 2 deletions Mathlib/Data/Countable/Small.lean
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import Mathlib.Logic.Small.Basic
import Mathlib.Data.Countable.Defs

#align_import data.countable.small from "leanprover-community/mathlib"@"bbeb185db4ccee8ed07dc48449414ebfa39cb821"
#align_import data.fintype.small from "leanprover-community/mathlib"@"1126441d6bccf98c81214a0780c73d499f6721fe"

/-!
# All countable types are small.
Expand All @@ -17,7 +18,14 @@ That is, any countable type is equivalent to a type in any universe.

universe w v

instance (priority := 100) small_of_countable (α : Type v) [Countable α] : Small.{w} α :=
instance (priority := 100) Countable.toSmall (α : Type v) [Countable α] : Small.{w} α :=
let ⟨_, hf⟩ := exists_injective_nat α
small_of_injective hf
#align small_of_countable small_of_countable
#align small_of_countable Countable.toSmall
#align small_of_fintype Countable.toSmall

@[deprecated, nolint defLemma] -- 2024-03-20
alias small_of_countable := Countable.toSmall

@[deprecated, nolint defLemma] -- 2024-03-20
alias small_of_fintype := Countable.toSmall
24 changes: 0 additions & 24 deletions Mathlib/Data/Fintype/Small.lean

This file was deleted.

3 changes: 1 addition & 2 deletions Mathlib/Logic/Small/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ theorem small_of_injective_of_exists {α : Type v} {β : Type w} {γ : Type v'}
infer_instance

/-!
We don't define `small_of_fintype` or `small_of_countable` in this file,
to keep imports to `Logic` to a minimum.
We don't define `Countable.toSmall` in this file, to keep imports to `Logic` to a minimum.
-/

instance small_Pi {α} (β : α → Type*) [Small.{w} α] [∀ a, Small.{w} (β a)] :
Expand Down
Loading