[Merged by Bors] - perf(Topology.Algebra.Module): factor out smul
#11331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
|
Here are the benchmark results for commit 3c14401. Benchmark Metric Change
===========================================================================
+ ~Mathlib.Analysis.Calculus.FDeriv.Mul instructions -8.9%
+ ~Mathlib.Analysis.InnerProductSpace.Adjoint instructions -10.4%
+ ~Mathlib.Analysis.InnerProductSpace.Basic instructions -4.7%
+ ~Mathlib.Analysis.NormedSpace.OperatorNorm.Bilinear instructions -13.0%
+ ~Mathlib.Analysis.NormedSpace.Star.Multiplier instructions -5.9%
+ ~Mathlib.Geometry.Manifold.ContMDiff.NormedSpace instructions -12.6% |
mattrobball
added
the
awaiting-review
YaelDillies
reviewed
Mar 23, 2024
Comment on lines
341
to
342
| @[simp, nolint simpNF] -- `simp` times out trying to find `Module ℂ (E →L[ℂ] ℂ)` but this fine | ||
| -- with all of `Mathlib` opened -- no idea why |
There was a problem hiding this comment.
Better english now hopefully
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
YaelDillies
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
That looks fine but what's the interaction with https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2311521.20speeding.20up.20lots.20of.20instances ? Won't that discussion make this PR obsolete soon?
jcommelin
added
awaiting-author
|
So it in fact works in tandem. |
mattrobball
added
awaiting-review
|
Okay, let's go maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
leanprover-community-mathlib4-bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
smulsmul
mathlib-bors
bot
deleted the
mrb/factor_out_data_topology_algebra_module
branch
loefflerd
added a commit
that referenced
this pull request
Apr 1, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to avoid making Lean unfold
smulduring unification. A separate instance does helps at the cost of some elaboration failures.