[Merged by Bors] - perf(Group.Units): factor out data fields #11332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
|
Here are the benchmark results for commit 9e7d158. Benchmark Metric Change
========================================================================
- build linting 5.5%
- ~Mathlib.CategoryTheory.Monoidal.Internal.Module instructions 5.2%
+ ~Mathlib.NumberTheory.NumberField.Discriminant instructions -5.6%
+ ~Mathlib.NumberTheory.NumberField.Units instructions -16.6% |
urkud
reviewed
Mar 15, 2024
mattrobball
added
the
awaiting-review
semorrison
reviewed
Mar 26, 2024
|
bors d+ |
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
Co-authored-by: Scott Morrison <scott@tqft.net>
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
We factor out data fields to avoid unecessary unfolding. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
We factor out data fields to avoid unecessary unfolding. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
We factor out data fields to avoid unecessary unfolding. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
We factor out data fields to avoid unecessary unfolding. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
We factor out data fields to avoid unecessary unfolding. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We factor out data fields to avoid unecessary unfolding.