Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.GCDMonoid.Basic #1135

Closed
wants to merge 25 commits into from
Closed

[Merged by Bors] - feat: port Algebra.GCDMonoid.Basic #1135

wants to merge 25 commits into from

Conversation

winstonyin
Copy link
Collaborator

@winstonyin winstonyin commented Dec 21, 2022 •
edited by bors bot

No description provided.

@winstonyin winstonyin added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Dec 23, 2022
@winstonyin
Copy link
Collaborator Author

I've marked those proofs which are taking a while to compile, if somebody wants to optimise them for speed.

Ruben-VandeVelde
Ruben-VandeVelde requested changes Dec 23, 2022
View reviewed changes
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 24, 2022
winstonyin and others added 6 commits December 26, 2022 15:12
@winstonyin @Ruben-VandeVelde
Update Mathlib/Algebra/GCDMonoid/Basic.lean
e199f6b 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@winstonyin @Ruben-VandeVelde
Update Mathlib/Algebra/GCDMonoid/Basic.lean
910fbd7 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@winstonyin @Ruben-VandeVelde
Update Mathlib/Algebra/GCDMonoid/Basic.lean
ab999e9 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@winstonyin
remove protected again
541eb5e
@winstonyin
@fun -> fun {...}
e5e60a8
@winstonyin
apply -> exact
53b5a4e
winstonyin added a commit that referenced this pull request Dec 27, 2022
@winstonyin
anticipate Associated.lean to be fixed by #1135
b12e847
@winstonyin winstonyin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 27, 2022
ChrisHughes24 and others added 2 commits December 29, 2022 13:08
@ChrisHughes24 @Ruben-VandeVelde
Update Mathlib/Algebra/GCDMonoid/Basic.lean
4cb6362 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@ChrisHughes24 @Ruben-VandeVelde
Apply suggestions from code review
807c859 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 2, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 3, 2023
dupuisf
dupuisf reviewed Jan 3, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Algebra/GCDMonoid/Basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 3, 2023

✌️ winstonyin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 3, 2023
hrmacbeth and others added 2 commits January 3, 2023 13:14
@hrmacbeth @dupuisf
Update Mathlib/Algebra/GCDMonoid/Basic.lean
d913c44 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@hrmacbeth
fix
489b1de
@hrmacbeth
Copy link
Member

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 3, 2023
bors bot pushed a commit that referenced this pull request Jan 3, 2023
@winstonyin @ChrisHughes24 @hrmacbeth
feat: port Algebra.GCDMonoid.Basic (#1135)
bfe06a7 
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 3, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.GCDMonoid.Basic [Merged by Bors] - feat: port Algebra.GCDMonoid.Basic Jan 3, 2023
@bors bors bot closed this Jan 3, 2023
@bors bors bot deleted the gcd_monoid_basic branch January 3, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde requested changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@winstonyin @hrmacbeth @dupuisf @Ruben-VandeVelde @semorrison @jcommelin @ChrisHughes24