Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(NumberTheory/Padics/PadicVal): Add padicValNat_mul_pow_left/right #11354

Closed
wants to merge 5 commits into from

Conversation

gaetanserre
Copy link
Collaborator

@gaetanserre gaetanserre commented Mar 13, 2024

Add two theorems solving goals of this form: for any primes p and q such that p != q, padicValNat p (p^n * q^m) = n


Open in Gitpod

…ght`

Add two theorems solving goals of this form: for any primes `p` and `q` such that `p != q`, `padicValNat p (p^n * q^m) = n`
@gaetanserre gaetanserre changed the title feat(NumberTheory/Padics/PadicVal): Add `padicValNat_prod_pow_left/ri… feat(NumberTheory/Padics/PadicVal): Add padicValNat_prod_pow_left/right Mar 13, 2024
@gaetanserre gaetanserre added the awaiting-review The author would like community review of the PR label Mar 13, 2024
Copy link
Collaborator

@BoltonBailey BoltonBailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (see my suggestion below)

Mathlib/NumberTheory/Padics/PadicVal.lean Outdated Show resolved Hide resolved
@BoltonBailey BoltonBailey added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 16, 2024
@gaetanserre gaetanserre added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 17, 2024
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder how often we'll have both [Fact p.Prime] and [Fact q.Prime] available but in any case there is nothing controversial here.

Thanks!

bors d+

Mathlib/NumberTheory/Padics/PadicVal.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Padics/PadicVal.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Padics/PadicVal.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 5, 2024

✌️ gaetanserre can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 5, 2024
@gaetanserre gaetanserre changed the title feat(NumberTheory/Padics/PadicVal): Add padicValNat_prod_pow_left/right feat(NumberTheory/Padics/PadicVal): Add padicValNat_mul_pow_left/right Apr 5, 2024
Co-authored-by: Oliver Nash <github@olivernash.org>
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! label Apr 5, 2024
@gaetanserre
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2024
…ht` (#11354)

Add two theorems solving goals of this form: for any primes `p` and `q` such that `p != q`, `padicValNat p (p^n * q^m) = n`




Co-authored-by: Gaëtan Serré <56162277+gaetanserre@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 5, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2024
…ht` (#11354)

Add two theorems solving goals of this form: for any primes `p` and `q` such that `p != q`, `padicValNat p (p^n * q^m) = n`




Co-authored-by: Gaëtan Serré <56162277+gaetanserre@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 5, 2024

Build failed (retrying...):

  • Build

mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2024
…ht` (#11354)

Add two theorems solving goals of this form: for any primes `p` and `q` such that `p != q`, `padicValNat p (p^n * q^m) = n`




Co-authored-by: Gaëtan Serré <56162277+gaetanserre@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberTheory/Padics/PadicVal): Add padicValNat_mul_pow_left/right [Merged by Bors] - feat(NumberTheory/Padics/PadicVal): Add padicValNat_mul_pow_left/right Apr 5, 2024
@mathlib-bors mathlib-bors bot closed this Apr 5, 2024
@mathlib-bors mathlib-bors bot deleted the gaetanserre_padicVal-prod-powered-primes branch April 5, 2024 20:49
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…ht` (#11354)

Add two theorems solving goals of this form: for any primes `p` and `q` such that `p != q`, `padicValNat p (p^n * q^m) = n`




Co-authored-by: Gaëtan Serré <56162277+gaetanserre@users.noreply.github.com>
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…ht` (#11354)

Add two theorems solving goals of this form: for any primes `p` and `q` such that `p != q`, `padicValNat p (p^n * q^m) = n`




Co-authored-by: Gaëtan Serré <56162277+gaetanserre@users.noreply.github.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…ht` (#11354)

Add two theorems solving goals of this form: for any primes `p` and `q` such that `p != q`, `padicValNat p (p^n * q^m) = n`




Co-authored-by: Gaëtan Serré <56162277+gaetanserre@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…ht` (#11354)

Add two theorems solving goals of this form: for any primes `p` and `q` such that `p != q`, `padicValNat p (p^n * q^m) = n`




Co-authored-by: Gaëtan Serré <56162277+gaetanserre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants