Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: fix todo for sigmaFinsuppEquivDFinsupp_smul #11355

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: fix todo for sigmaFinsuppEquivDFinsupp_smul #11355

wants to merge 2 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Mar 13, 2024
alreadydone
alreadydone approved these changes Mar 13, 2024
View reviewed changes
Mathlib/Data/Finsupp/ToDFinsupp.lean Outdated Show resolved Hide resolved
Mathlib/Data/Finsupp/ToDFinsupp.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde @alreadydone
Apply suggestions from code review
a6c7083 
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@alreadydone
Copy link
Contributor

Thanks
maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

jcommelin
jcommelin approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 14, 2024
@Ruben-VandeVelde
chore: fix todo for sigmaFinsuppEquivDFinsupp_smul (#11355)
ac06536
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix todo for sigmaFinsuppEquivDFinsupp_smul [Merged by Bors] - chore: fix todo for sigmaFinsuppEquivDFinsupp_smul Mar 14, 2024
@mathlib-bors mathlib-bors bot closed this Mar 14, 2024
@mathlib-bors mathlib-bors bot deleted the sigmaFinsuppEquivDFinsupp_smul branch March 14, 2024 08:28
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@Ruben-VandeVelde @dagurtomas
chore: fix todo for sigmaFinsuppEquivDFinsupp_smul (#11355)
8f07339
utensil pushed a commit that referenced this pull request Mar 26, 2024
@Ruben-VandeVelde @utensil
chore: fix todo for sigmaFinsuppEquivDFinsupp_smul (#11355)
1dfad06
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@Ruben-VandeVelde @Louddy
chore: fix todo for sigmaFinsuppEquivDFinsupp_smul (#11355)
4c22ff4
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@Ruben-VandeVelde @uniwuni
chore: fix todo for sigmaFinsuppEquivDFinsupp_smul (#11355)
b6c0c5f
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@Ruben-VandeVelde @callesonne
chore: fix todo for sigmaFinsuppEquivDFinsupp_smul (#11355)
ee8c039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ruben-VandeVelde @alreadydone @jcommelin @leanprover-community-mathlib4-bot