[Merged by Bors] - refactor: new definition of eigenvectorUnitary
#11363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunweg
added
the
new-contributor
leanprover-community-mathlib4-bot
added
the
merge-conflict
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
leanprover-community-mathlib4-bot
removed
the
merge-conflict
…but it isn't that bad.
j-loreaux
reviewed
May 2, 2024
Want to remove mul_vec and vec_mul lemmas and then address issues with #align commands
…nk_eq_rank_diagonal broke.
by using tactic mode.
…ral" alignment with previously existing lemmas.
Replaced Hermitian conjugate with star. Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
j-loreaux
reviewed
May 3, 2024
Jireh's suggestion, more explicit eigenvectorBasis Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
…com/leanprover-community/mathlib4 into jbannon/Spectrum.eigenvectorUnitary
JonBannon
added
awaiting-review
|
I've had a lot of input in this, so it would be good to get a second set of eyes. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by j-loreaux. |
j-loreaux
changed the title
eigenvectorUnitary
|
Definitely 👍
…On Fri, May 3, 2024, 12:52 PM Jireh Loreaux ***@***.***> wrote:
I've had a lot of input in this, so it would be good to get a second set
of eyes.
maintainer merge
—
Reply to this email directly, view it on GitHub
<#11363 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJJJTURPHUYLLPOTCS4ZVTZAO6EBAVCNFSM6AAAAABEVA72J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGM4TCNBUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 4, 2024
This file contains the spectral theorem for Hermitian matrices and nearby relevant theorems. We rewrote the file, recasting the natural eigenvector basis matrix as a unitary called `eigenvectorUnitary`, and removed a lot of defeq abuse that the original file contained, considerably simplifying things. Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
eigenvectorUnitaryeigenvectorUnitary
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
This file contains the spectral theorem for Hermitian matrices and nearby relevant theorems. We rewrote the file, recasting the natural eigenvector basis matrix as a unitary called `eigenvectorUnitary`, and removed a lot of defeq abuse that the original file contained, considerably simplifying things. Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
This file contains the spectral theorem for Hermitian matrices and nearby relevant theorems. We rewrote the file, recasting the natural eigenvector basis matrix as a unitary called `eigenvectorUnitary`, and removed a lot of defeq abuse that the original file contained, considerably simplifying things. Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file contains the spectral theorem for Hermitian matrices and nearby relevant theorems. We rewrote the file, recasting the natural eigenvector basis matrix as a unitary called
eigenvectorUnitary, and removed a lot of defeq abuse that the original file contained, considerably simplifying things.rank_mul_eq_left_of_isUnit_detinto an effectivesimplemma #12244