New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: add lemmas Polynomial.natDegree_sum_le_of_forall_le
#11381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add two missing `simp` attributes
ocfnash
added
awaiting-review
The author would like community review of the PR
easy
< 20s of review time. See the lifecycle page for guidelines.
awaiting-CI
t-algebra
Algebra (groups, rings, fields etc)
labels
Mar 14, 2024
adomani
reviewed
Mar 14, 2024
Co-authored-by: damiano <adomani@gmail.com>
adomani
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I do not know if it is ok to maintainer merge PRs that have not passed CI, but I'll do it anyway! 🏴☠️
maintainer merge
🚀 Pull request has been placed on the maintainer queue by adomani. |
bors r+ |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 15, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
Also add two missing `simp` attributes
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
feat: add lemmas
[Merged by Bors] - feat: add lemmas Mar 15, 2024
Polynomial.natDegree_sum_le_of_forall_le
Polynomial.natDegree_sum_le_of_forall_le
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Also add two missing `simp` attributes
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
Also add two missing `simp` attributes
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Also add two missing `simp` attributes
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Also add two missing `simp` attributes
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Also add two missing `simp` attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
easy
< 20s of review time. See the lifecycle page for guidelines.
maintainer-merge
ready-to-merge
This PR has been sent to bors.
t-algebra
Algebra (groups, rings, fields etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add two missing
simp
attributes