[Merged by Bors] - chore: remove unneeded decreasing_by and termination_by #11386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-review
|
LGTM. Thanks! There is an overlap with #11388 which is currently on the queue. AFAICT, the overlap won't generate merge conflicts. bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
The termination checker has been getting more capable, and many of the `termination_by` or `decreasing_by` clauses in Mathlib are no longer needed. (Note that `termination_by?` will show the automatically derived termination expression, so no information is being lost by removing these.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
!bench Note that there is a performance penalty if you don't specify the measure, so I don't know if I actually recommend removing these annotations if you already have them. |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
|
Here are the benchmark results for commit 0a38691. |
|
Ok, the speedcenter alleviates my worries. Thanks! |
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
The termination checker has been getting more capable, and many of the `termination_by` or `decreasing_by` clauses in Mathlib are no longer needed. (Note that `termination_by?` will show the automatically derived termination expression, so no information is being lost by removing these.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
The termination checker has been getting more capable, and many of the `termination_by` or `decreasing_by` clauses in Mathlib are no longer needed. (Note that `termination_by?` will show the automatically derived termination expression, so no information is being lost by removing these.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
The termination checker has been getting more capable, and many of the `termination_by` or `decreasing_by` clauses in Mathlib are no longer needed. (Note that `termination_by?` will show the automatically derived termination expression, so no information is being lost by removing these.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
The termination checker has been getting more capable, and many of the `termination_by` or `decreasing_by` clauses in Mathlib are no longer needed. (Note that `termination_by?` will show the automatically derived termination expression, so no information is being lost by removing these.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
The termination checker has been getting more capable, and many of the `termination_by` or `decreasing_by` clauses in Mathlib are no longer needed. (Note that `termination_by?` will show the automatically derived termination expression, so no information is being lost by removing these.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The termination checker has been getting more capable, and many of the
termination_byordecreasing_byclauses in Mathlib are no longer needed.(Note that
termination_by?will show the automatically derived termination expression, so no information is being lost by removing these.)Pinging @nomeata as they might be pleased to see what is now possible!