Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: label one porting note and fix another #11411

Closed
wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Mar 15, 2024

Two comments with Lean 3 code looked like they should have been labelled "porting note".
Do so; one of them can be fixed now.


Open in Gitpod

@grunweg grunweg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 15, 2024
@sgouezel
Copy link
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 16, 2024
Two comments with Lean 3 code looked like they should have been labelled "porting note".
Do so; one of them can be fixed now.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: label one porting note and fix another [Merged by Bors] - chore: label one porting note and fix another Mar 16, 2024
@mathlib-bors mathlib-bors bot closed this Mar 16, 2024
@mathlib-bors mathlib-bors bot deleted the MR-add-porting-notes branch March 16, 2024 17:34
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Two comments with Lean 3 code looked like they should have been labelled "porting note".
Do so; one of them can be fixed now.
utensil pushed a commit that referenced this pull request Mar 26, 2024
Two comments with Lean 3 code looked like they should have been labelled "porting note".
Do so; one of them can be fixed now.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Two comments with Lean 3 code looked like they should have been labelled "porting note".
Do so; one of them can be fixed now.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Two comments with Lean 3 code looked like they should have been labelled "porting note".
Do so; one of them can be fixed now.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Two comments with Lean 3 code looked like they should have been labelled "porting note".
Do so; one of them can be fixed now.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Two comments with Lean 3 code looked like they should have been labelled "porting note".
Do so; one of them can be fixed now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants