[Merged by Bors] - chore(*): Fintype -> Finite, drop Decidable #11423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, in some cases drop unneeded `Fintype` arguments.
urkud
added
t-differential-geometry
urkud
commented
Mar 16, 2024
| #align matrix.diagonal_smul Matrix.diagonal_smul | ||
|
|
||
| @[simp] | ||
| theorem diagonal_neg [DecidableEq n] [NegZeroClass α] (d : n → α) : | ||
| theorem diagonal_neg [NegZeroClass α] (d : n → α) : |
There was a problem hiding this comment.
This [DecidableEq n] duplicated an instance in variable.
urkud
added
the
easy
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
Also, in some cases drop unneeded `Fintype` arguments.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Also, in some cases drop unneeded `Fintype` arguments.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
Also, in some cases drop unneeded `Fintype` arguments.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Also, in some cases drop unneeded `Fintype` arguments.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Also, in some cases drop unneeded `Fintype` arguments.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Also, in some cases drop unneeded `Fintype` arguments.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Also, in some cases drop unneeded `Fintype` arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, in some cases drop unneeded
Fintypearguments.