-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - golf: replace some apply foo.mpr
by rw [foo]
#11515
Conversation
!bench |
Here are the benchmark results for commit dc49269. |
apply foo.mpr
by rw [foo]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of these are an improvement.
I have two minor suggestions (if they compile).
bors d+
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Thank you for the fast review. Both suggestions compile. |
Sometimes, that line can be golfed into the next line. Inspired by a [comment](#11208 (comment)) of @loefflerd; any decisions are my own.
Pull request successfully merged into master. Build succeeded: |
apply foo.mpr
by rw [foo]
apply foo.mpr
by rw [foo]
Sometimes, that line can be golfed into the next line. Inspired by a [comment](#11208 (comment)) of @loefflerd; any decisions are my own.
Sometimes, that line can be golfed into the next line. Inspired by a [comment](#11208 (comment)) of @loefflerd; any decisions are my own.
Sometimes, that line can be golfed into the next line. Inspired by a [comment](#11208 (comment)) of @loefflerd; any decisions are my own.
Sometimes, that line can be golfed into the next line. Inspired by a [comment](#11208 (comment)) of @loefflerd; any decisions are my own.
Sometimes, that line can be golfed into the next line. Inspired by a [comment](#11208 (comment)) of @loefflerd; any decisions are my own.
Sometimes, that line can be golfed into the next line. Inspired by a [comment](#11208 (comment)) of @loefflerd; any decisions are my own.
Sometimes, that line can be golfed into the next line.
Inspired by a comment of @loefflerd; any decisions are my own.
(I'm happy to drop some of these changes if they're actually dubious.)