[Merged by Bors] - chore: drop use of trivial in use
#1153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
the
awaiting-review
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
After filling an existential, `use` will resolve the remaining goals if they are "easy". Before this PR this was done by trying `trivial`. I have downgraded to `with_reducible rfl`. This means `use` will no longer solve goals which are - definitional equalities which require the unfolding of non-reducible definitions - tactics other than `rfl` which are called by `trivial` (notably `decide`, which can get slow) Note that this brings `use` closer to the mathlib3 version: there it tried the `trivial'` tactic, which again only looked at definitional equality up to reducible definitions, and whose kitchen-sink did not include `decide`. See discussion: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/use
|
Build failed (retrying...):
|
bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
After filling an existential, `use` will resolve the remaining goals if they are "easy". Before this PR this was done by trying `trivial`. I have downgraded to `with_reducible rfl`. This means `use` will no longer solve goals which are - definitional equalities which require the unfolding of non-reducible definitions - tactics other than `rfl` which are called by `trivial` (notably `decide`, which can get slow) Note that this brings `use` closer to the mathlib3 version: there it tried the `trivial'` tactic, which again only looked at definitional equality up to reducible definitions, and whose kitchen-sink did not include `decide`. See discussion: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/use
|
Build failed:
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
After filling an existential, `use` will resolve the remaining goals if they are "easy". Before this PR this was done by trying `trivial`. I have downgraded to `with_reducible rfl`. This means `use` will no longer solve goals which are - definitional equalities which require the unfolding of non-reducible definitions - tactics other than `rfl` which are called by `trivial` (notably `decide`, which can get slow) Note that this brings `use` closer to the mathlib3 version: there it tried the `trivial'` tactic, which again only looked at definitional equality up to reducible definitions, and whose kitchen-sink did not include `decide`. See discussion: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/use
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
trivial in usetrivial in use
jcommelin
pushed a commit
that referenced
this pull request
Jan 23, 2023
After filling an existential, `use` will resolve the remaining goals if they are "easy". Before this PR this was done by trying `trivial`. I have downgraded to `with_reducible rfl`. This means `use` will no longer solve goals which are - definitional equalities which require the unfolding of non-reducible definitions - tactics other than `rfl` which are called by `trivial` (notably `decide`, which can get slow) Note that this brings `use` closer to the mathlib3 version: there it tried the `trivial'` tactic, which again only looked at definitional equality up to reducible definitions, and whose kitchen-sink did not include `decide`. See discussion: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After filling an existential,
usewill resolve the remaining goals if they are "easy". Before this PR this was done by tryingtrivial. I have downgraded towith_reducible rfl. This meansusewill no longer solve goals which arerflwhich are called bytrivial(notablydecide, which can get slow)Note that this brings
usecloser to the mathlib3 version: there it tried thetrivial'tactic, which again only looked at definitional equality up to reducible definitions, and whose kitchen-sink did not includedecide.See discussion:
https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/use