Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Set/Finset): standardize names of distributivity laws #11572

Closed
wants to merge 14 commits into from

Conversation

FordUniver
Copy link
Collaborator

@FordUniver FordUniver commented Mar 21, 2024

Standardizes the following names for distributivity laws across Finset and Set:

  • inter_union_distrib_left
  • inter_union_distrib_right
  • union_inter_distrib_left
  • union_inter_distrib_right

Makes arguments explicit in:

  • Set.union_inter_distrib_right
  • Set.union_inter_distrib_left
  • Set.inter_union_distrib_right

Deprecates these theorem names:

  • Finset.inter_distrib_left
  • Finset.inter_distrib_right
  • Finset.union_distrib_right
  • Finset.union_distrib_left
  • Set.inter_distrib_left
  • Set.inter_distrib_right
  • Set.union_distrib_right
  • Set.union_distrib_left

Fixes use of deprecated names and implicit arguments in these files:

  • Topology/Basic
  • Topology/Connected/Basic
  • MeasureTheory/MeasurableSpace/Basic
  • MeasureTheory/Covering/Differentiation
  • MeasureTheory/Constructions/BorelSpace/Basic
  • Data/Set/Image
  • Data/Set/Basic
  • Data/PFun
  • Data/Matroid/Dual
  • Data/Finset/Sups
  • Data/Finset/Basic
  • Combinatorics/SetFamily/FourFunctions
  • Combinatorics/Additive/SalemSpencer
  • Counterexamples/Phillips.lean
  • Archive/Imo/Imo2021Q1.lean

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and in other places.

Mathlib/Data/Finset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Finset/Basic.lean Outdated Show resolved Hide resolved
@YaelDillies
Copy link
Collaborator

You should add -- 2024-03-22 before each (block of) @[deprecated] so that we know how old the deprecation is.

FordUniver and others added 2 commits March 22, 2024 13:56
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Mar 22, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 22, 2024
Standardizes the following names for distributivity laws across `Finset` and `Set`:

- `inter_union_distrib_left`
- `inter_union_distrib_right`
- `union_inter_distrib_left`
- `union_inter_distrib_right`

Makes arguments explicit in:

- `Set.union_inter_distrib_right`
- `Set.union_inter_distrib_left`
- `Set.inter_union_distrib_right`

Deprecates these theorem names:

- `Finset.inter_distrib_left`
- `Finset.inter_distrib_right`
- `Finset.union_distrib_right`
- `Finset.union_distrib_left`
- `Set.inter_distrib_left`
- `Set.inter_distrib_right`
- `Set.union_distrib_right`
- `Set.union_distrib_left`

Fixes use of deprecated names and implicit arguments in these files:

- Topology/Basic
- Topology/Connected/Basic
- MeasureTheory/MeasurableSpace/Basic
- MeasureTheory/Covering/Differentiation
- MeasureTheory/Constructions/BorelSpace/Basic
- Data/Set/Image
- Data/Set/Basic
- Data/PFun
- Data/Matroid/Dual
- Data/Finset/Sups
- Data/Finset/Basic
- Combinatorics/SetFamily/FourFunctions
- Combinatorics/Additive/SalemSpencer
- Counterexamples/Phillips.lean
- Archive/Imo/Imo2021Q1.lean
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Set/Finset): standardize names of distributivity laws [Merged by Bors] - chore(Set/Finset): standardize names of distributivity laws Mar 22, 2024
@mathlib-bors mathlib-bors bot closed this Mar 22, 2024
@mathlib-bors mathlib-bors bot deleted the FordUniver/FinsetSetChore branch March 22, 2024 15:32
@grunweg grunweg added the new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! label Mar 25, 2024
utensil pushed a commit that referenced this pull request Mar 26, 2024
Standardizes the following names for distributivity laws across `Finset` and `Set`:

- `inter_union_distrib_left`
- `inter_union_distrib_right`
- `union_inter_distrib_left`
- `union_inter_distrib_right`

Makes arguments explicit in:

- `Set.union_inter_distrib_right`
- `Set.union_inter_distrib_left`
- `Set.inter_union_distrib_right`

Deprecates these theorem names:

- `Finset.inter_distrib_left`
- `Finset.inter_distrib_right`
- `Finset.union_distrib_right`
- `Finset.union_distrib_left`
- `Set.inter_distrib_left`
- `Set.inter_distrib_right`
- `Set.union_distrib_right`
- `Set.union_distrib_left`

Fixes use of deprecated names and implicit arguments in these files:

- Topology/Basic
- Topology/Connected/Basic
- MeasureTheory/MeasurableSpace/Basic
- MeasureTheory/Covering/Differentiation
- MeasureTheory/Constructions/BorelSpace/Basic
- Data/Set/Image
- Data/Set/Basic
- Data/PFun
- Data/Matroid/Dual
- Data/Finset/Sups
- Data/Finset/Basic
- Combinatorics/SetFamily/FourFunctions
- Combinatorics/Additive/SalemSpencer
- Counterexamples/Phillips.lean
- Archive/Imo/Imo2021Q1.lean
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Standardizes the following names for distributivity laws across `Finset` and `Set`:

- `inter_union_distrib_left`
- `inter_union_distrib_right`
- `union_inter_distrib_left`
- `union_inter_distrib_right`

Makes arguments explicit in:

- `Set.union_inter_distrib_right`
- `Set.union_inter_distrib_left`
- `Set.inter_union_distrib_right`

Deprecates these theorem names:

- `Finset.inter_distrib_left`
- `Finset.inter_distrib_right`
- `Finset.union_distrib_right`
- `Finset.union_distrib_left`
- `Set.inter_distrib_left`
- `Set.inter_distrib_right`
- `Set.union_distrib_right`
- `Set.union_distrib_left`

Fixes use of deprecated names and implicit arguments in these files:

- Topology/Basic
- Topology/Connected/Basic
- MeasureTheory/MeasurableSpace/Basic
- MeasureTheory/Covering/Differentiation
- MeasureTheory/Constructions/BorelSpace/Basic
- Data/Set/Image
- Data/Set/Basic
- Data/PFun
- Data/Matroid/Dual
- Data/Finset/Sups
- Data/Finset/Basic
- Combinatorics/SetFamily/FourFunctions
- Combinatorics/Additive/SalemSpencer
- Counterexamples/Phillips.lean
- Archive/Imo/Imo2021Q1.lean
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Standardizes the following names for distributivity laws across `Finset` and `Set`:

- `inter_union_distrib_left`
- `inter_union_distrib_right`
- `union_inter_distrib_left`
- `union_inter_distrib_right`

Makes arguments explicit in:

- `Set.union_inter_distrib_right`
- `Set.union_inter_distrib_left`
- `Set.inter_union_distrib_right`

Deprecates these theorem names:

- `Finset.inter_distrib_left`
- `Finset.inter_distrib_right`
- `Finset.union_distrib_right`
- `Finset.union_distrib_left`
- `Set.inter_distrib_left`
- `Set.inter_distrib_right`
- `Set.union_distrib_right`
- `Set.union_distrib_left`

Fixes use of deprecated names and implicit arguments in these files:

- Topology/Basic
- Topology/Connected/Basic
- MeasureTheory/MeasurableSpace/Basic
- MeasureTheory/Covering/Differentiation
- MeasureTheory/Constructions/BorelSpace/Basic
- Data/Set/Image
- Data/Set/Basic
- Data/PFun
- Data/Matroid/Dual
- Data/Finset/Sups
- Data/Finset/Basic
- Combinatorics/SetFamily/FourFunctions
- Combinatorics/Additive/SalemSpencer
- Counterexamples/Phillips.lean
- Archive/Imo/Imo2021Q1.lean
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Standardizes the following names for distributivity laws across `Finset` and `Set`:

- `inter_union_distrib_left`
- `inter_union_distrib_right`
- `union_inter_distrib_left`
- `union_inter_distrib_right`

Makes arguments explicit in:

- `Set.union_inter_distrib_right`
- `Set.union_inter_distrib_left`
- `Set.inter_union_distrib_right`

Deprecates these theorem names:

- `Finset.inter_distrib_left`
- `Finset.inter_distrib_right`
- `Finset.union_distrib_right`
- `Finset.union_distrib_left`
- `Set.inter_distrib_left`
- `Set.inter_distrib_right`
- `Set.union_distrib_right`
- `Set.union_distrib_left`

Fixes use of deprecated names and implicit arguments in these files:

- Topology/Basic
- Topology/Connected/Basic
- MeasureTheory/MeasurableSpace/Basic
- MeasureTheory/Covering/Differentiation
- MeasureTheory/Constructions/BorelSpace/Basic
- Data/Set/Image
- Data/Set/Basic
- Data/PFun
- Data/Matroid/Dual
- Data/Finset/Sups
- Data/Finset/Basic
- Combinatorics/SetFamily/FourFunctions
- Combinatorics/Additive/SalemSpencer
- Counterexamples/Phillips.lean
- Archive/Imo/Imo2021Q1.lean
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Standardizes the following names for distributivity laws across `Finset` and `Set`:

- `inter_union_distrib_left`
- `inter_union_distrib_right`
- `union_inter_distrib_left`
- `union_inter_distrib_right`

Makes arguments explicit in:

- `Set.union_inter_distrib_right`
- `Set.union_inter_distrib_left`
- `Set.inter_union_distrib_right`

Deprecates these theorem names:

- `Finset.inter_distrib_left`
- `Finset.inter_distrib_right`
- `Finset.union_distrib_right`
- `Finset.union_distrib_left`
- `Set.inter_distrib_left`
- `Set.inter_distrib_right`
- `Set.union_distrib_right`
- `Set.union_distrib_left`

Fixes use of deprecated names and implicit arguments in these files:

- Topology/Basic
- Topology/Connected/Basic
- MeasureTheory/MeasurableSpace/Basic
- MeasureTheory/Covering/Differentiation
- MeasureTheory/Constructions/BorelSpace/Basic
- Data/Set/Image
- Data/Set/Basic
- Data/PFun
- Data/Matroid/Dual
- Data/Finset/Sups
- Data/Finset/Basic
- Combinatorics/SetFamily/FourFunctions
- Combinatorics/Additive/SalemSpencer
- Counterexamples/Phillips.lean
- Archive/Imo/Imo2021Q1.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants