New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: change authorship of Leibniz series proof #11578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Parcly-Taxel
commented
Mar 22, 2024
•
edited
edited
The new proof was written from scratch even though it uses the same idea to extend convergence to `x = 1`, so arguably I am the author of this file, not Benjamin Davidson.
Parcly-Taxel
added
the
awaiting-review
The author would like community review of the PR
label
Mar 22, 2024
You can not change the initial author of a file, nor the 100.yaml entry (it is about the first proof in Lean). You can definitely add yourself as another author to the file, though. |
sgouezel
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 22, 2024
Parcly-Taxel
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Mar 22, 2024
bors r+ |
github-actions
bot
removed
the
awaiting-review
The author would like community review of the PR
label
Mar 22, 2024
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore: change authorship of Leibniz series proof
[Merged by Bors] - chore: change authorship of Leibniz series proof
Mar 22, 2024
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.