Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: change authorship of Leibniz series proof #11578

Closed
wants to merge 3 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

@Parcly-Taxel Parcly-Taxel commented Mar 22, 2024


Open in Gitpod

The new proof was written from scratch even though it uses the same idea to extend convergence to `x = 1`, so arguably I am the author of this file, not Benjamin Davidson.
@Parcly-Taxel Parcly-Taxel added the awaiting-review The author would like community review of the PR label Mar 22, 2024
@sgouezel
Copy link
Contributor

You can not change the initial author of a file, nor the 100.yaml entry (it is about the first proof in Lean). You can definitely add yourself as another author to the file, though.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 22, 2024
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 22, 2024
@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 22, 2024
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Mar 22, 2024
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: change authorship of Leibniz series proof [Merged by Bors] - chore: change authorship of Leibniz series proof Mar 22, 2024
@mathlib-bors mathlib-bors bot closed this Mar 22, 2024
@mathlib-bors mathlib-bors bot deleted the leibniz-author branch March 22, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants