Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - style: remove redundant instance arguments #11581

Closed
wants to merge 3 commits into from

Conversation

JovanGerb
Copy link
Collaborator

@JovanGerb JovanGerb commented Mar 22, 2024

I removed some redundant instance arguments throughout Mathlib. To do this, I used VS Code's regex search. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/repeating.20instances.20from.20variable.20command
I closed the previous PR for this and reopened it.


Open in Gitpod

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this in too much detail and all seems to be in order.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 24, 2024
I removed some redundant instance arguments throughout Mathlib. To do this, I used VS Code's regex search. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/repeating.20instances.20from.20variable.20command
I closed the previous PR for this and reopened it.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 24, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Mar 24, 2024
I removed some redundant instance arguments throughout Mathlib. To do this, I used VS Code's regex search. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/repeating.20instances.20from.20variable.20command
I closed the previous PR for this and reopened it.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title style: remove redundant instance arguments [Merged by Bors] - style: remove redundant instance arguments Mar 24, 2024
@mathlib-bors mathlib-bors bot closed this Mar 24, 2024
@mathlib-bors mathlib-bors bot deleted the removeArgs branch March 24, 2024 09:49
utensil pushed a commit that referenced this pull request Mar 26, 2024
I removed some redundant instance arguments throughout Mathlib. To do this, I used VS Code's regex search. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/repeating.20instances.20from.20variable.20command
I closed the previous PR for this and reopened it.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
I removed some redundant instance arguments throughout Mathlib. To do this, I used VS Code's regex search. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/repeating.20instances.20from.20variable.20command
I closed the previous PR for this and reopened it.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
I removed some redundant instance arguments throughout Mathlib. To do this, I used VS Code's regex search. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/repeating.20instances.20from.20variable.20command
I closed the previous PR for this and reopened it.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
I removed some redundant instance arguments throughout Mathlib. To do this, I used VS Code's regex search. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/repeating.20instances.20from.20variable.20command
I closed the previous PR for this and reopened it.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
I removed some redundant instance arguments throughout Mathlib. To do this, I used VS Code's regex search. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/repeating.20instances.20from.20variable.20command
I closed the previous PR for this and reopened it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants