Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(SetTheory/Cardinal/Basic): add sections structuring the file better #11603

Closed
wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Mar 23, 2024

This file is overly long: add some sections to structure the material better.

And tweak one line break to be more logical.


This raises some immediate ideas how to split this file

  • move the sets section to a new file
  • powerlt could (presumably) be split
  • more radically, one could try to split off an entire file defs
    All of these are out of scope of this PR.

Open in Gitpod

@grunweg grunweg added the awaiting-review The author would like community review of the PR label Mar 23, 2024
@grunweg grunweg marked this pull request as ready for review March 23, 2024 14:49
@ocfnash
Copy link
Contributor

ocfnash commented Apr 6, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 6, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 6, 2024
…tter (#11603)

This file is overly long: add some sections to structure the material better.

And tweak one line break to be more logical.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(SetTheory/Cardinal/Basic): add sections structuring the file better [Merged by Bors] - chore(SetTheory/Cardinal/Basic): add sections structuring the file better Apr 6, 2024
@mathlib-bors mathlib-bors bot closed this Apr 6, 2024
@mathlib-bors mathlib-bors bot deleted the MR-cardinal-basic branch April 6, 2024 14:26
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…tter (#11603)

This file is overly long: add some sections to structure the material better.

And tweak one line break to be more logical.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…tter (#11603)

This file is overly long: add some sections to structure the material better.

And tweak one line break to be more logical.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…tter (#11603)

This file is overly long: add some sections to structure the material better.

And tweak one line break to be more logical.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…tter (#11603)

This file is overly long: add some sections to structure the material better.

And tweak one line break to be more logical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants