[Merged by Bors] - chore: rename misnamed lemmas involving isOpenMap #11607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunweg
added
awaiting-review
grunweg
commented
Mar 23, 2024
grunweg
force-pushed
the
MR-rename-openxy
branch
from
8ab35c2
to
c9bf9a4
Compare
|
Should we use |
|
Very good point - I think we should. Fixed. |
|
Thanks! 🎉 |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
- open_map_of_strict_deriv -> isOpenMap_of_hasStrictDerivAt - open_map_of_strict_fderiv_equiv -> isOpenMap_of_hasStrictFderivAt_equiv These lemmas have conclusion `isOpenMap`, hence should be named accordingly.
|
Thank you for the fast review! |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
- open_map_of_strict_deriv -> isOpenMap_of_hasStrictDerivAt - open_map_of_strict_fderiv_equiv -> isOpenMap_of_hasStrictFderivAt_equiv These lemmas have conclusion `isOpenMap`, hence should be named accordingly.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
- open_map_of_strict_deriv -> isOpenMap_of_hasStrictDerivAt - open_map_of_strict_fderiv_equiv -> isOpenMap_of_hasStrictFderivAt_equiv These lemmas have conclusion `isOpenMap`, hence should be named accordingly.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
- open_map_of_strict_deriv -> isOpenMap_of_hasStrictDerivAt - open_map_of_strict_fderiv_equiv -> isOpenMap_of_hasStrictFderivAt_equiv These lemmas have conclusion `isOpenMap`, hence should be named accordingly.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
- open_map_of_strict_deriv -> isOpenMap_of_hasStrictDerivAt - open_map_of_strict_fderiv_equiv -> isOpenMap_of_hasStrictFderivAt_equiv These lemmas have conclusion `isOpenMap`, hence should be named accordingly.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
- open_map_of_strict_deriv -> isOpenMap_of_hasStrictDerivAt - open_map_of_strict_fderiv_equiv -> isOpenMap_of_hasStrictFderivAt_equiv These lemmas have conclusion `isOpenMap`, hence should be named accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lemmas have conclusion
isOpenMap, hence should be named accordingly.