Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Algebra.Module): make Function.Surjective.module reducible #11631

Closed
wants to merge 1 commit into from

Conversation

mattrobball
Copy link
Collaborator

This is used to construct instances of classes and needs to be reducible to unfold during unification performed in the process of typeclass synthesis, see the library note [reducible non-instances]


Open in Gitpod

@mattrobball mattrobball added awaiting-review The author would like community review of the PR awaiting-CI labels Mar 24, 2024
@mattrobball
Copy link
Collaborator Author

!bench

@mattrobball mattrobball added the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 24, 2024
@mattrobball
Copy link
Collaborator Author

Labelled easy assuming the benchmark is neutral or better.

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 301c6af.
There were no significant changes against commit 971aea7.

@kmill
Copy link
Contributor

kmill commented Mar 24, 2024

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 24, 2024
…11631)

This is used to construct instances of classes and needs to be reducible to unfold during unification performed in the process of typeclass synthesis, see the library note [reducible non-instances]
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra.Module): make Function.Surjective.module reducible [Merged by Bors] - chore(Algebra.Module): make Function.Surjective.module reducible Mar 24, 2024
@mathlib-bors mathlib-bors bot closed this Mar 24, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/bad_inst2 branch March 24, 2024 20:38
Louddy pushed a commit that referenced this pull request Mar 25, 2024
…11631)

This is used to construct instances of classes and needs to be reducible to unfold during unification performed in the process of typeclass synthesis, see the library note [reducible non-instances]
utensil pushed a commit that referenced this pull request Mar 26, 2024
…11631)

This is used to construct instances of classes and needs to be reducible to unfold during unification performed in the process of typeclass synthesis, see the library note [reducible non-instances]
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…11631)

This is used to construct instances of classes and needs to be reducible to unfold during unification performed in the process of typeclass synthesis, see the library note [reducible non-instances]
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…11631)

This is used to construct instances of classes and needs to be reducible to unfold during unification performed in the process of typeclass synthesis, see the library note [reducible non-instances]
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…11631)

This is used to construct instances of classes and needs to be reducible to unfold during unification performed in the process of typeclass synthesis, see the library note [reducible non-instances]
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…11631)

This is used to construct instances of classes and needs to be reducible to unfold during unification performed in the process of typeclass synthesis, see the library note [reducible non-instances]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants