Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Tropical.Basic #1165

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Tropical.Basic #1165

wants to merge 9 commits into from

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Dec 22, 2022 •
edited

Main change here was making Tropical irreducible because it seemed to fix things.

@ChrisHughes24 ChrisHughes24 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 22, 2022
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 23, 2022
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 31, 2022
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 4, 2023
jcommelin
jcommelin reviewed Jan 5, 2023
View reviewed changes
Mathlib/Algebra/Tropical/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Tropical/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Tropical/Basic.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 5, 2023
ChrisHughes24 and others added 2 commits January 5, 2023 11:47
@ChrisHughes24 @jcommelin
Apply suggestions from code review
bd75232 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ChrisHughes24
update porting notes
af38cf2
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 5, 2023
jcommelin
jcommelin approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 5, 2023
bors bot pushed a commit that referenced this pull request Jan 5, 2023
@ChrisHughes24 @hrmacbeth
feat: port Algebra.Tropical.Basic (#1165)
cac724d 
Main change here was making `Tropical` irreducible because it seemed to fix things.

Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 5, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Tropical.Basic [Merged by Bors] - feat: port Algebra.Tropical.Basic Jan 5, 2023
@bors bors bot closed this Jan 5, 2023
@bors bors bot deleted the Algebra.Tropical.Basic branch January 5, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrisHughes24 @jcommelin @semorrison @hrmacbeth