Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(List/ReduceOption): move from Basic.lean #11662

Closed
wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 25, 2024

Also rename List.IsPrefix.filter_map to List.IsPrefix.filterMap
and protect some theorems in the List.IsPrefix namespace.


Open in Gitpod

Also rename `List.IsPrefix.filter_map` to `List.IsPrefix.filterMap`
and protect some theorems in the `List.IsPrefix` namespace.
@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-logic Logic (model theory, set theory, etc) labels Mar 25, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems plausible to me. Thank you for doing this!

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 26, 2024
Also rename `List.IsPrefix.filter_map` to `List.IsPrefix.filterMap`
and protect some theorems in the `List.IsPrefix` namespace.
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(List/ReduceOption): move from Basic.lean [Merged by Bors] - chore(List/ReduceOption): move from Basic.lean Mar 26, 2024
@mathlib-bors mathlib-bors bot closed this Mar 26, 2024
@mathlib-bors mathlib-bors bot deleted the YK-reduce-opt branch March 26, 2024 15:23
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Also rename `List.IsPrefix.filter_map` to `List.IsPrefix.filterMap`
and protect some theorems in the `List.IsPrefix` namespace.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Also rename `List.IsPrefix.filter_map` to `List.IsPrefix.filterMap`
and protect some theorems in the `List.IsPrefix` namespace.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Also rename `List.IsPrefix.filter_map` to `List.IsPrefix.filterMap`
and protect some theorems in the `List.IsPrefix` namespace.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Also rename `List.IsPrefix.filter_map` to `List.IsPrefix.filterMap`
and protect some theorems in the `List.IsPrefix` namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants