Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: typo in module doc of NumberTheory/Cyclotomic/Basic #11670

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: typo in module doc of NumberTheory/Cyclotomic/Basic #11670

wants to merge 1 commit into from

Conversation

fpvandoorn
Copy link
Member

Open in Gitpod

@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Mar 25, 2024
@riccardobrasca
Copy link
Member

The file is NumberTheory/Cyclotomic/Basic, can you please fix the title?

@fpvandoorn fpvandoorn changed the title fix: typo in module doc of Cyclotomic/Basic fix: typo in module doc of NumberTheory/Cyclotomic/Basic Mar 25, 2024
@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 25, 2024

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Mar 25, 2024
@fpvandoorn
Copy link
Member Author

bors r+

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 25, 2024

👎 Rejected by label

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-CI labels Mar 25, 2024
@fpvandoorn
Copy link
Member Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Mar 25, 2024
@fpvandoorn
fix: typo in module doc of NumberTheory/Cyclotomic/Basic (#11670)
103d868
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: typo in module doc of NumberTheory/Cyclotomic/Basic [Merged by Bors] - fix: typo in module doc of NumberTheory/Cyclotomic/Basic Mar 25, 2024
@mathlib-bors mathlib-bors bot closed this Mar 25, 2024
@mathlib-bors mathlib-bors bot deleted the FvD/cyclotomic_typo branch March 25, 2024 21:55
utensil pushed a commit that referenced this pull request Mar 26, 2024
@fpvandoorn @utensil
fix: typo in module doc of NumberTheory/Cyclotomic/Basic (#11670)
985d8a3
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@fpvandoorn @Louddy
fix: typo in module doc of NumberTheory/Cyclotomic/Basic (#11670)
64ca324
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
@fpvandoorn @atarnoam
fix: typo in module doc of NumberTheory/Cyclotomic/Basic (#11670)
bcfb6e2
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@fpvandoorn @uniwuni
fix: typo in module doc of NumberTheory/Cyclotomic/Basic (#11670)
bda5ae5
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@fpvandoorn @callesonne
fix: typo in module doc of NumberTheory/Cyclotomic/Basic (#11670)
20819c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpvandoorn @riccardobrasca