Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/Finset/Powerset): Fix decidability instances #11672

Closed
wants to merge 5 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Typeclass search cannot synthesize ∀ t ⊆ s, Decidable (p t) hypothesis, hence the instance could never fire. Fix it and compress back the binders, both in the instancs and Combinatorics.Additive.SalemSpencer where they were supposed to be used.


Open in Gitpod

Typeclass search cannot sy,thesize `∀ t ⊆ s, Decidable (p t)` hypothesis, hence the instance could never fire. Fix it and compress back the binders, both in the instancs and `Combinatorics.Additive.SalemSpencer` where they were supposed to be used.
@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Mar 25, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 27, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 27, 2024
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Combinatorics/Additive/SalemSpencer.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 16, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 16, 2024
Copy link
Collaborator Author

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 16, 2024
Typeclass search cannot synthesize `∀ t ⊆ s, Decidable (p t)` hypothesis, hence the instance could never fire. Fix it and compress back the binders, both in the instancs and `Combinatorics.Additive.SalemSpencer` where they were supposed to be used.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Finset/Powerset): Fix decidability instances [Merged by Bors] - chore(Data/Finset/Powerset): Fix decidability instances Apr 16, 2024
@mathlib-bors mathlib-bors bot closed this Apr 16, 2024
@mathlib-bors mathlib-bors bot deleted the finset_decidable_forall branch April 16, 2024 22:37
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Typeclass search cannot synthesize `∀ t ⊆ s, Decidable (p t)` hypothesis, hence the instance could never fire. Fix it and compress back the binders, both in the instancs and `Combinatorics.Additive.SalemSpencer` where they were supposed to be used.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Typeclass search cannot synthesize `∀ t ⊆ s, Decidable (p t)` hypothesis, hence the instance could never fire. Fix it and compress back the binders, both in the instancs and `Combinatorics.Additive.SalemSpencer` where they were supposed to be used.
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
Typeclass search cannot synthesize `∀ t ⊆ s, Decidable (p t)` hypothesis, hence the instance could never fire. Fix it and compress back the binders, both in the instancs and `Combinatorics.Additive.SalemSpencer` where they were supposed to be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants