Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: fix two porting notes #11682

Closed
wants to merge 2 commits into from
Closed

Conversation

semorrison
Copy link
Contributor

Fix two porting notes (one that should have been a porting note!) while looking at on_goals.

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Mar 26, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 26, 2024
Fix two porting notes (one that should have been a porting note!) while looking at `on_goals`.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix two porting notes [Merged by Bors] - chore: fix two porting notes Mar 26, 2024
@mathlib-bors mathlib-bors bot closed this Mar 26, 2024
@mathlib-bors mathlib-bors bot deleted the porting_notes branch March 26, 2024 11:02
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Fix two porting notes (one that should have been a porting note!) while looking at `on_goals`.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Fix two porting notes (one that should have been a porting note!) while looking at `on_goals`.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Fix two porting notes (one that should have been a porting note!) while looking at `on_goals`.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Fix two porting notes (one that should have been a porting note!) while looking at `on_goals`.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants