Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/List/Enum): move from Basic #11697

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - chore(Data/List/Enum): move from Basic #11697

wants to merge 10 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 26, 2024

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-logic Logic (model theory, set theory, etc) labels Mar 26, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 26, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 26, 2024
grunweg
grunweg approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this qualifies as "easy", given Github's interface - I checked locally that this is purely code motion and import changes. Looks good to me.
Thank you for doing this!

@urkud urkud removed the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 27, 2024
@urkud
Copy link
Member Author

urkud commented Mar 27, 2024

OK, removed easy.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 27, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 27, 2024
@urkud urkud mentioned this pull request Apr 7, 2024
Closed
2 tasks
@urkud urkud requested a review from eric-wieser April 13, 2024 15:12
eric-wieser
eric-wieser approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

I'll take @grunweg's word for it that this is a move with no other changes

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 16, 2024
@urkud
chore(Data/List/Enum): move from Basic (#11697)
7fe076e
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 16, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 17, 2024
@urkud
chore(Data/List/Enum): move from Basic (#11697)
e1dfe02
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 17, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 17, 2024
@urkud
chore(Data/List/Enum): move from Basic (#11697)
7885f47
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 17, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 17, 2024
@urkud
chore(Data/List/Enum): move from Basic (#11697)
063b1da
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 17, 2024

Build failed:

@urkud
Copy link
Member Author

urkud commented Apr 17, 2024

Let me fix the build
bors r-

@grunweg grunweg added awaiting-review The author would like community review of the PR and removed ready-to-merge This PR has been sent to bors. labels Apr 17, 2024
@grunweg
Copy link
Collaborator

grunweg commented Apr 17, 2024

@eric-wieser If I see correctly, this is off the bors queue. Can you approve again, if you agree with the changes?

@sgouezel
Copy link
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 17, 2024
@urkud
chore(Data/List/Enum): move from Basic (#11697)
6d66f4c
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/List/Enum): move from Basic [Merged by Bors] - chore(Data/List/Enum): move from Basic Apr 17, 2024
@mathlib-bors mathlib-bors bot closed this Apr 17, 2024
@mathlib-bors mathlib-bors bot deleted the YK-move-enum branch April 17, 2024 14:48
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@urkud @uniwuni
chore(Data/List/Enum): move from Basic (#11697)
ef61239
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@urkud @callesonne
chore(Data/List/Enum): move from Basic (#11697)
f1e2c02
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
@urkud @Jun2M
chore(Data/List/Enum): move from Basic (#11697)
95b2fa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@grunweg grunweg grunweg approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@urkud @grunweg @sgouezel @eric-wieser @leanprover-community-mathlib4-bot