Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: Reduce scope of LinearOrderedCommGroupWithZero #11716

Closed
wants to merge 17 commits into from
Closed

[Merged by Bors] - chore: Reduce scope of LinearOrderedCommGroupWithZero #11716

wants to merge 17 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Mar 27, 2024 •
edited

Reconstitute the file Algebra.Order.Monoid.WithZero from three files:

  • Algebra.Order.Monoid.WithZero.Defs
  • Algebra.Order.Monoid.WithZero.Basic
  • Algebra.Order.WithZero

Avoid importing it in many files. Most uses were just to get le_zero_iff to work on Nat.

Before
pre_11716

After
post_11716

Open in Gitpod

@YaelDillies
chore: Reduce scope of LinearOrderedCommGroupWithZero
cb5027a 
Reconstitute the file `Algebra.Order.Monoid.WithZero` from three files:
* `Algebra.Order.Monoid.WithZero.Defs`
* `Algebra.Order.Monoid.WithZero.Basic`
* `Algebra.Order.WithZero`

Avoid importing it in many files. Most uses were just to get `le_zero_iff` to work on `Nat`.
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR awaiting-CI labels Mar 27, 2024
@YaelDillies YaelDillies mentioned this pull request Mar 27, 2024
Open
16 tasks
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 27, 2024
@YaelDillies
chore: Reduce scope of LinearOrderedCommGroupWithZero (#11716)
0708043 
Reconstitute the file `Algebra.Order.Monoid.WithZero` from three files:
* `Algebra.Order.Monoid.WithZero.Defs`
* `Algebra.Order.Monoid.WithZero.Basic`
* `Algebra.Order.WithZero`

Avoid importing it in many files. Most uses were just to get `le_zero_iff` to work on `Nat`.

Before
![pre_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/f7296277-67e3-47b1-9ecf-33f84ea11010)

After
![post_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/1aa508ce-3f52-485d-b251-4127dd208bdc)
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 27, 2024

Build failed:

@jcommelin
Copy link
Member

bors r+

@jcommelin
Copy link
Member

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 28, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Mar 28, 2024
@YaelDillies
chore: Reduce scope of LinearOrderedCommGroupWithZero (#11716)
bb349f3 
Reconstitute the file `Algebra.Order.Monoid.WithZero` from three files:
* `Algebra.Order.Monoid.WithZero.Defs`
* `Algebra.Order.Monoid.WithZero.Basic`
* `Algebra.Order.WithZero`

Avoid importing it in many files. Most uses were just to get `le_zero_iff` to work on `Nat`.

Before
![pre_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/f7296277-67e3-47b1-9ecf-33f84ea11010)

After
![post_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/1aa508ce-3f52-485d-b251-4127dd208bdc)
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Reduce scope of LinearOrderedCommGroupWithZero [Merged by Bors] - chore: Reduce scope of LinearOrderedCommGroupWithZero Mar 28, 2024
@mathlib-bors mathlib-bors bot closed this Mar 28, 2024
@mathlib-bors mathlib-bors bot deleted the kill_order_with_zero branch March 28, 2024 12:59
@YaelDillies YaelDillies mentioned this pull request Mar 28, 2024
Open
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@YaelDillies @Louddy
chore: Reduce scope of LinearOrderedCommGroupWithZero (#11716)
4373058 
Reconstitute the file `Algebra.Order.Monoid.WithZero` from three files:
* `Algebra.Order.Monoid.WithZero.Defs`
* `Algebra.Order.Monoid.WithZero.Basic`
* `Algebra.Order.WithZero`

Avoid importing it in many files. Most uses were just to get `le_zero_iff` to work on `Nat`.

Before
![pre_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/f7296277-67e3-47b1-9ecf-33f84ea11010)

After
![post_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/1aa508ce-3f52-485d-b251-4127dd208bdc)
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
@YaelDillies @atarnoam
chore: Reduce scope of LinearOrderedCommGroupWithZero (#11716)
851e678 
Reconstitute the file `Algebra.Order.Monoid.WithZero` from three files:
* `Algebra.Order.Monoid.WithZero.Defs`
* `Algebra.Order.Monoid.WithZero.Basic`
* `Algebra.Order.WithZero`

Avoid importing it in many files. Most uses were just to get `le_zero_iff` to work on `Nat`.

Before
![pre_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/f7296277-67e3-47b1-9ecf-33f84ea11010)

After
![post_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/1aa508ce-3f52-485d-b251-4127dd208bdc)
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@YaelDillies @uniwuni
chore: Reduce scope of LinearOrderedCommGroupWithZero (#11716)
007b4ba 
Reconstitute the file `Algebra.Order.Monoid.WithZero` from three files:
* `Algebra.Order.Monoid.WithZero.Defs`
* `Algebra.Order.Monoid.WithZero.Basic`
* `Algebra.Order.WithZero`

Avoid importing it in many files. Most uses were just to get `le_zero_iff` to work on `Nat`.

Before
![pre_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/f7296277-67e3-47b1-9ecf-33f84ea11010)

After
![post_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/1aa508ce-3f52-485d-b251-4127dd208bdc)
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@YaelDillies @callesonne
chore: Reduce scope of LinearOrderedCommGroupWithZero (#11716)
933a98f 
Reconstitute the file `Algebra.Order.Monoid.WithZero` from three files:
* `Algebra.Order.Monoid.WithZero.Defs`
* `Algebra.Order.Monoid.WithZero.Basic`
* `Algebra.Order.WithZero`

Avoid importing it in many files. Most uses were just to get `le_zero_iff` to work on `Nat`.

Before
![pre_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/f7296277-67e3-47b1-9ecf-33f84ea11010)

After
![post_11716](https://github.com/leanprover-community/mathlib4/assets/14090593/1aa508ce-3f52-485d-b251-4127dd208bdc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @semorrison @jcommelin