Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/List/Join): better notation #11724

Closed
wants to merge 1 commit into from

Conversation

madvorak
Copy link
Collaborator

@madvorak madvorak commented Mar 27, 2024

Summary of changes (all changes are cosmetic):

  • use L for a 2D lists instead of l consistently
  • use dot notation more
  • use anonymous function argument

Open in Gitpod

@madvorak madvorak added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 27, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for doing this. As I understand it, this PR mostly

  • uses L for a list (instead of l) more consistently
  • uses dot notation more.
    Can you add this to the PR description, please?

@madvorak
Copy link
Collaborator Author

madvorak commented Apr 4, 2024

There are two different notations with "dots" that I used here. I don't know how to call the latter in words.

@grunweg
Copy link
Collaborator

grunweg commented Apr 4, 2024

For me, "dot notation" is writing "hf.image" instead of "IsCompact.image hf" (when hf has type IsCompact ...).
I guess I would call the other notation an "anonymous function argument".

@j-loreaux
Copy link
Collaborator

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 7, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 7, 2024
Summary of changes (all changes are cosmetic):
* use `L` for a 2D lists instead of `l` consistently
* use dot notation more
* use anonymous function argument
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 7, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/List/Join): better notation [Merged by Bors] - chore(Data/List/Join): better notation Apr 7, 2024
@mathlib-bors mathlib-bors bot closed this Apr 7, 2024
@mathlib-bors mathlib-bors bot deleted the list-join-refak branch April 7, 2024 05:06
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Summary of changes (all changes are cosmetic):
* use `L` for a 2D lists instead of `l` consistently
* use dot notation more
* use anonymous function argument
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Summary of changes (all changes are cosmetic):
* use `L` for a 2D lists instead of `l` consistently
* use dot notation more
* use anonymous function argument
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Summary of changes (all changes are cosmetic):
* use `L` for a 2D lists instead of `l` consistently
* use dot notation more
* use anonymous function argument
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Summary of changes (all changes are cosmetic):
* use `L` for a 2D lists instead of `l` consistently
* use dot notation more
* use anonymous function argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants