Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Set.Pairwise #1175

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port Data.Set.Pairwise #1175

wants to merge 10 commits into from

Conversation

zeramorphic
Copy link
Collaborator

@zeramorphic zeramorphic commented Dec 22, 2022 •
edited by bors bot

No description provided.

@zeramorphic
Copy from mathport
372f56f 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Initial fixes
84a8b09 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic zeramorphic added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 22, 2022
@zeramorphic
File compiles
b71707c 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Fix warnings and lints
99bca7e 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Naming fixes
e289ef1 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Comment fixes
8c40b33 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic zeramorphic removed the WIP Work in progress label Dec 22, 2022
@zeramorphic
Some naming fixes
89e4066 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic zeramorphic mentioned this pull request Dec 23, 2022
Closed
@zeramorphic
Copy link
Collaborator Author

We have a race condition between two PRs, this and #1176: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Data.2ESet.2EPairwise

dupuisf
dupuisf reviewed Dec 23, 2022
View reviewed changes
Mathlib/Data/Set/Pairwise.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Pairwise.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Pairwise.lean Outdated Show resolved Hide resolved
@dupuisf dupuisf added the awaiting-review The author would like community review of the PR label Dec 23, 2022
@zeramorphic @dupuisf
Apply suggestions from code review
f6c7a3c 
Co-authored-by: dupuisf <dupuisf@iro.umontreal.ca>
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@negiizhao negiizhao mentioned this pull request Dec 23, 2022
Closed
2 tasks
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 24, 2022
@zeramorphic
Copy link
Collaborator Author

Thanks for making those changes.

@zeramorphic zeramorphic added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 24, 2022
@rwbarton
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 24, 2022
bors bot pushed a commit that referenced this pull request Dec 24, 2022
@zeramorphic @rwbarton
feat: port Data.Set.Pairwise (#1175)
863ab3e 
Co-authored-by: Reid Barton <rwbarton@gmail.com>
@bors
Copy link

bors bot commented Dec 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Set.Pairwise [Merged by Bors] - feat: port Data.Set.Pairwise Dec 24, 2022
@bors bors bot closed this Dec 24, 2022
@bors bors bot deleted the Data.Set.Pairwise branch December 24, 2022 11:49
@github-actions github-actions bot mentioned this pull request Dec 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwbarton rwbarton rwbarton left review comments

@jcommelin jcommelin jcommelin left review comments

@negiizhao negiizhao negiizhao left review comments

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zeramorphic @rwbarton @jcommelin @negiizhao @dupuisf