Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: characterize totally disconnected sets in orders #11752

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: characterize totally disconnected sets in orders #11752

wants to merge 4 commits into from

Conversation

fpvandoorn
Copy link
Member

Open in Gitpod

@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR awaiting-CI t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order hierarchy labels Mar 28, 2024
@urkud
Copy link
Member

urkud commented Apr 18, 2024

I added some optional golf suggestions. Also, please add a docstring to lemma isTotallyDisconnected_iff_lt.

Otherwise LGTM. Thanks!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 18, 2024

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 18, 2024
@fpvandoorn
Copy link
Member Author

Thanks for the golfs!

@fpvandoorn
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 18, 2024
@fpvandoorn
feat: characterize totally disconnected sets in orders (#11752)
fa2a388
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: characterize totally disconnected sets in orders [Merged by Bors] - feat: characterize totally disconnected sets in orders Apr 18, 2024
@mathlib-bors mathlib-bors bot closed this Apr 18, 2024
@mathlib-bors mathlib-bors bot deleted the totallydisconnected_order branch April 18, 2024 12:51
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@fpvandoorn @uniwuni
feat: characterize totally disconnected sets in orders (#11752)
ea1071b
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@fpvandoorn @callesonne
feat: characterize totally disconnected sets in orders (#11752)
2739c9f
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
@fpvandoorn @Jun2M
feat: characterize totally disconnected sets in orders (#11752)
fed33fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-order Order hierarchy t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpvandoorn @urkud