Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: bundled versions of two operations on continuous multilinear maps #11775

Closed
wants to merge 6 commits into from

Conversation

sgouezel
Copy link
Contributor

We provide versions of smulRight and compContinuousLinearMap as a continuous bilinear (resp multilinear) map.


Open in Gitpod

@sgouezel sgouezel added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Mar 29, 2024
Copy link
Collaborator

@rosborn rosborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not sure mathlib's official position on when to use the change tactic in the library, so feel free to ignore that comment.

Mathlib/Analysis/NormedSpace/Multilinear/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/NormedSpace/Multilinear/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/NormedSpace/Multilinear/Basic.lean Outdated Show resolved Hide resolved
@sgouezel
Copy link
Contributor Author

Thanks for the review! change is not really an issue when we are sure that definitions won't change (which is the case here), but still your suggestion looks better so I've committed it.

@ocfnash
Copy link
Contributor

ocfnash commented Apr 1, 2024

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 1, 2024
…ps (#11775)

We provide versions of `smulRight` and `compContinuousLinearMap` as a continuous bilinear (resp multilinear) map.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Apr 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: bundled versions of two operations on continuous multilinear maps [Merged by Bors] - feat: bundled versions of two operations on continuous multilinear maps Apr 1, 2024
@mathlib-bors mathlib-bors bot closed this Apr 1, 2024
@mathlib-bors mathlib-bors bot deleted the SG_multilinear branch April 1, 2024 16:53
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…ps (#11775)

We provide versions of `smulRight` and `compContinuousLinearMap` as a continuous bilinear (resp multilinear) map.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…ps (#11775)

We provide versions of `smulRight` and `compContinuousLinearMap` as a continuous bilinear (resp multilinear) map.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…ps (#11775)

We provide versions of `smulRight` and `compContinuousLinearMap` as a continuous bilinear (resp multilinear) map.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…ps (#11775)

We provide versions of `smulRight` and `compContinuousLinearMap` as a continuous bilinear (resp multilinear) map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants