Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Finset/Basic): drop an unneeded DecidableEq assumption #11796

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Finset/Basic): drop an unneeded DecidableEq assumption #11796

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 30, 2024

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-logic Logic (model theory, set theory, etc) labels Mar 30, 2024
@ADedecker
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 31, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 31, 2024
@urkud
chore(Finset/Basic): drop an unneeded DecidableEq assumption (#11796)
c5b0516
@eric-wieser
Copy link
Member

This looks like a very strong argument for leanprover/lean4#2452. We should make sure to reference that issue in these PRs in future to provide evidence for the priority.

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 31, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Finset/Basic): drop an unneeded DecidableEq assumption [Merged by Bors] - chore(Finset/Basic): drop an unneeded DecidableEq assumption Mar 31, 2024
@mathlib-bors mathlib-bors bot closed this Mar 31, 2024
@mathlib-bors mathlib-bors bot deleted the YK-finset-cons branch March 31, 2024 21:48
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@urkud @Louddy
chore(Finset/Basic): drop an unneeded DecidableEq assumption (#11796)
90bdbc7
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
@urkud @atarnoam
chore(Finset/Basic): drop an unneeded DecidableEq assumption (#11796)
2f62498
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@urkud @uniwuni
chore(Finset/Basic): drop an unneeded DecidableEq assumption (#11796)
d5f7b29
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@urkud @callesonne
chore(Finset/Basic): drop an unneeded DecidableEq assumption (#11796)
2947119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @ADedecker @eric-wieser