Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: pointwise scalar multiplication is monotone #11809

Closed
wants to merge 16 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 31, 2024

Everywhere we have a smul_mem_pointwise_smul lemma, I've added this result.


Open in Gitpod

Should this be stated with a typeclass? If so, what's the API lemma that recovers this result? done

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Mar 31, 2024
eric-wieser and others added 2 commits April 1, 2024 08:53
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

Copy link

github-actions bot commented Apr 2, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.


variable {ι : Sort*} {M α : Type*}

theorem smul_mono_right [SMul M α] [Preorder α] [CovariantClass M α HSMul.hSMul LE.le]
Copy link
Member

@fpvandoorn fpvandoorn Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a version with the gcongr attribute (I think it has to be formulated separately using \le).

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 2, 2024

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@fpvandoorn fpvandoorn added delegated and removed awaiting-review The author would like community review of the PR labels Apr 2, 2024
@fpvandoorn
Copy link
Member

apparently the label bot doesn't work from comments to the code.

@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2024
Everywhere we have a `smul_mem_pointwise_smul` lemma, I've added this result.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: pointwise scalar multiplication is monotone [Merged by Bors] - feat: pointwise scalar multiplication is monotone Apr 3, 2024
@mathlib-bors mathlib-bors bot closed this Apr 3, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/smul_mono branch April 3, 2024 00:37
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Everywhere we have a `smul_mem_pointwise_smul` lemma, I've added this result.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Everywhere we have a `smul_mem_pointwise_smul` lemma, I've added this result.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Everywhere we have a `smul_mem_pointwise_smul` lemma, I've added this result.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Everywhere we have a `smul_mem_pointwise_smul` lemma, I've added this result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants