[Merged by Bors] - chore(RingTheory): delete useless lemma #11827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederic-marbach
added
awaiting-review
ocfnash
approved these changes
Apr 1, 2024
| @@ -3,6 +3,7 @@ Copyright (c) 2020 Scott Morrison. All rights reserved. | |||
| Released under Apache 2.0 license as described in the file LICENSE. | |||
| Authors: Scott Morrison | |||
| -/ | |||
| import Mathlib.Algebra.BigOperators.Basic | |||
There was a problem hiding this comment.
I note that you are not adding an import, merely making it explicit that we depend on this file.
| @@ -324,7 +325,7 @@ theorem sum_smul (n : ℕ) : | |||
| simp only [← nat_cast_mul, Nat.succ_eq_add_one, Nat.add_succ_sub_one, add_zero, pow_succ] | |||
| push_cast | |||
| ring | |||
| rw [add_pow, (pderiv true).map_sum, (MvPolynomial.aeval e).map_sum, Finset.sum_mul] | |||
| rw [add_pow, map_sum (pderiv true), (MvPolynomial.aeval e).map_sum, Finset.sum_mul] | |||
There was a problem hiding this comment.
Why not use the generic lemma here too:
Suggested change
| rw [add_pow, map_sum (pderiv true), (MvPolynomial.aeval e).map_sum, Finset.sum_mul] | |
| rw [add_pow, map_sum (pderiv true), map_sum (MvPolynomial.aeval e), Finset.sum_mul] |
|
✌️ frederic-marbach can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
As discussed in #11790 for the case of Lie derivations, it seems that this `map_sum` lemma is not useful since we can use the generic version.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
As discussed in #11790 for the case of Lie derivations, it seems that this `map_sum` lemma is not useful since we can use the generic version.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
As discussed in #11790 for the case of Lie derivations, it seems that this `map_sum` lemma is not useful since we can use the generic version.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
As discussed in #11790 for the case of Lie derivations, it seems that this `map_sum` lemma is not useful since we can use the generic version.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
As discussed in #11790 for the case of Lie derivations, it seems that this `map_sum` lemma is not useful since we can use the generic version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #11790 for the case of Lie derivations, it seems that this
map_sumlemma is not useful since we can use the generic version.