-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data/List): Do not depend on algebra #11845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`.
Ruben-VandeVelde
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 5, 2024
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 5, 2024
bors r+ |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
labels
Apr 5, 2024
Merge conflict. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 6, 2024
16 tasks
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 6, 2024
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before ![pre_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/5912261a-7c57-4231-a7d4-aed9ed7c8c79) After ![post_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/c523c187-2f5a-4d65-ba88-ae489855039e)
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(Data/List): Do not depend on algebra
[Merged by Bors] - chore(Data/List): Do not depend on algebra
Apr 6, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before ![pre_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/5912261a-7c57-4231-a7d4-aed9ed7c8c79) After ![post_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/c523c187-2f5a-4d65-ba88-ae489855039e)
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before ![pre_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/5912261a-7c57-4231-a7d4-aed9ed7c8c79) After ![post_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/c523c187-2f5a-4d65-ba88-ae489855039e)
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before ![pre_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/5912261a-7c57-4231-a7d4-aed9ed7c8c79) After ![post_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/c523c187-2f5a-4d65-ba88-ae489855039e)
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before ![pre_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/5912261a-7c57-4231-a7d4-aed9ed7c8c79) After ![post_11845](https://github.com/leanprover-community/mathlib4/assets/14090593/c523c187-2f5a-4d65-ba88-ae489855039e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependencies on algebra in the
Data.List
folder except for:Data.List.EditDistance
: Actually relies on algebra. Maybe should be moved?Data.List.Card
: Completely unused and redundant.Data.List.Cycle
: Relies onFintype
, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved?Data.List.Func
: Completely unused and redundant.Data.List.Lex
: That's order theory. Could be moved.Data.List.Prime
. That's algebra. Should definitely be moved.Data.List.Sym
: Relies onMultiset
, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved?Data.List.ToFinsupp
: That's algebra. Should definitely be moved.As a consequence, move the big operators lemmas that were in there to
Algebra.BigOperators.List.Basic
. For the lemmas that wereNat
-specific and not about auxiliary definitions, keep a version of them in the original file but stated usingNat.sum
.Before
After