Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add of_eq versions for lemmas on composition of derivatives #11867

Closed
wants to merge 3 commits into from

Conversation

sgouezel
Copy link
Contributor

@sgouezel sgouezel commented Apr 3, 2024

The versions we have assume that f is differentiable at h x and h is differentiable at x, to deduce that f o h is differentiable at x. In many applications, we have that f is differentiable at some point which happens to be equal to h x, but not definitionally, so one needs to jump through some hoops to apply the composition lemma. We add of_eq versions assuming instead that f is differentiable at y and that y = h x, which is much more flexible in practice.


This could be done throughout the library for many composition-like lemmas. I'm only doing it in the file Deriv.Comp in this PR.

Open in Gitpod

@sgouezel sgouezel added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Apr 3, 2024
@sgouezel sgouezel changed the title feat: add eq_on versions for lemmas on composition of derivatives feat: add of_eq versions for lemmas on composition of derivatives Apr 3, 2024
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Analysis/Calculus/Deriv/Comp.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Calculus/Deriv/Comp.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Calculus/Deriv/Comp.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Calculus/Deriv/Comp.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 5, 2024

✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 5, 2024
sgouezel and others added 2 commits April 6, 2024 09:08
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@sgouezel
Copy link
Contributor Author

sgouezel commented Apr 6, 2024

bors r+
Thanks for the review!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 6, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 6, 2024
…11867)

The versions we have assume that `f` is differentiable at `h x` and `h` is differentiable at `x`, to deduce that `f o h` is differentiable at `x`. In many applications, we have that `f` is differentiable at some point which happens to be equal to `h x`, but not definitionally, so one needs to jump through some hoops to apply the composition lemma. We add `of_eq` versions assuming instead that `f` is differentiable at `y` and that `y = h x`, which is much more flexible in practice.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add of_eq versions for lemmas on composition of derivatives [Merged by Bors] - feat: add of_eq versions for lemmas on composition of derivatives Apr 6, 2024
@mathlib-bors mathlib-bors bot closed this Apr 6, 2024
@mathlib-bors mathlib-bors bot deleted the SG_deriv_eq_on branch April 6, 2024 09:12
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…11867)

The versions we have assume that `f` is differentiable at `h x` and `h` is differentiable at `x`, to deduce that `f o h` is differentiable at `x`. In many applications, we have that `f` is differentiable at some point which happens to be equal to `h x`, but not definitionally, so one needs to jump through some hoops to apply the composition lemma. We add `of_eq` versions assuming instead that `f` is differentiable at `y` and that `y = h x`, which is much more flexible in practice.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…11867)

The versions we have assume that `f` is differentiable at `h x` and `h` is differentiable at `x`, to deduce that `f o h` is differentiable at `x`. In many applications, we have that `f` is differentiable at some point which happens to be equal to `h x`, but not definitionally, so one needs to jump through some hoops to apply the composition lemma. We add `of_eq` versions assuming instead that `f` is differentiable at `y` and that `y = h x`, which is much more flexible in practice.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…11867)

The versions we have assume that `f` is differentiable at `h x` and `h` is differentiable at `x`, to deduce that `f o h` is differentiable at `x`. In many applications, we have that `f` is differentiable at some point which happens to be equal to `h x`, but not definitionally, so one needs to jump through some hoops to apply the composition lemma. We add `of_eq` versions assuming instead that `f` is differentiable at `y` and that `y = h x`, which is much more flexible in practice.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…11867)

The versions we have assume that `f` is differentiable at `h x` and `h` is differentiable at `x`, to deduce that `f o h` is differentiable at `x`. In many applications, we have that `f` is differentiable at some point which happens to be equal to `h x`, but not definitionally, so one needs to jump through some hoops to apply the composition lemma. We add `of_eq` versions assuming instead that `f` is differentiable at `y` and that `y = h x`, which is much more flexible in practice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants