Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Finitely Presented Modules #11870

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: Finitely Presented Modules #11870

wants to merge 10 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Apr 3, 2024

Open in Gitpod

@erdOne erdOne added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Apr 3, 2024
kbuzzard
kbuzzard reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me. I left some comments.

Mathlib/Algebra/Module/FinitePresentation.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Module/FinitePresentation.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Module/FinitePresentation.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Module/FinitePresentation.lean Show resolved Hide resolved
Mathlib/Algebra/Module/FinitePresentation.lean
· rintro ⟨y, hy, rfl⟩
simp [f, hπ, ← Finsupp.apply_total, hy]

-- Ideally this should be an instance but it makes mathlib much slower.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with e.g. priority 90?

Mathlib/Algebra/Module/FinitePresentation.lean Outdated Show resolved Hide resolved
@riccardobrasca riccardobrasca self-assigned this Apr 22, 2024
erdOne and others added 3 commits April 26, 2024 11:23
@erdOne
address comments
33aec37
@erdOne @kbuzzard
Apply suggestions from code review
7b82e39 
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@erdOne
fix line too long
88bbfe1
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 26, 2024
@erdOne
feat: Finitely Presented Modules (#11870)
3e83c09 
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Finitely Presented Modules [Merged by Bors] - feat: Finitely Presented Modules Apr 26, 2024
@mathlib-bors mathlib-bors bot closed this Apr 26, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/fpModules branch April 26, 2024 18:08
apnelson1 pushed a commit that referenced this pull request May 12, 2024
@erdOne @apnelson1
feat: Finitely Presented Modules (#11870)
ff05774 
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request May 16, 2024
@erdOne @callesonne
feat: Finitely Presented Modules (#11870)
59e3e99 
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbuzzard kbuzzard kbuzzard left review comments

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees

@riccardobrasca riccardobrasca

Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erdOne @riccardobrasca @kbuzzard