New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Tactic/TypeStar): reduce imports #11876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it says, and there seems to be support for and no resistance against this particular change on zulip.
Thank you for making this change.
Thanks! I see that there are additions to shake. Should there also be some deletions, from the no longer imported Std? |
I just ran |
This is a question for @digama0. I suspect that an unused import should have an entry in Anyway, this is certainly not an issue with this PR! maintainer merge |
It auto-removes entries from |
Can we leave the shake-reconfiguration to a follow-up? |
Yes, I think that it does not make much sense to edit these Thanks! maintainer merge |
🚀 Pull request has been placed on the maintainer queue by adomani. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors merge
I noticed that this doesn't actually use `Std` or in fact any of its other imports. The downstream fallout is pretty small because `Mathlib.Tactic.Basic` imports `Std` anyway, so this only impacts files not downstream of that.
Pull request successfully merged into master. Build succeeded: |
I noticed that this doesn't actually use `Std` or in fact any of its other imports. The downstream fallout is pretty small because `Mathlib.Tactic.Basic` imports `Std` anyway, so this only impacts files not downstream of that.
I noticed that this doesn't actually use `Std` or in fact any of its other imports. The downstream fallout is pretty small because `Mathlib.Tactic.Basic` imports `Std` anyway, so this only impacts files not downstream of that.
I noticed that this doesn't actually use `Std` or in fact any of its other imports. The downstream fallout is pretty small because `Mathlib.Tactic.Basic` imports `Std` anyway, so this only impacts files not downstream of that.
I noticed that this doesn't actually use `Std` or in fact any of its other imports. The downstream fallout is pretty small because `Mathlib.Tactic.Basic` imports `Std` anyway, so this only impacts files not downstream of that.
I noticed that this doesn't actually use
Std
or in fact any of its other imports.The downstream fallout is pretty small because
Mathlib.Tactic.Basic
importsStd
anyway, so this only impacts files not downstream of that.